Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] [Bug] Index Values are not available in dropdown under New Index Enter for Knowledge Base. (#199610) #199990

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

e40pud
Copy link
Contributor

@e40pud e40pud commented Nov 13, 2024

Summary

This PR fixes the issue described here #199610 (comment)

In short, we do not show all indices with semantic_text fields. We only show those which have semantic_text fields named content.

Testing notes

Add the index with the semantic_text field by running this command in dev tools:

PUT test_index
{
  "mappings": {
  "properties": {
    "attachment": {
      "properties": {
        "content": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        },
        "content_length": {
          "type": "long"
        },
        "content_type": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        },
        "format": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        },
        "language": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        }
      }
    },
    "content2": {
      "type": "semantic_text",
      "inference_id": "elastic-security-ai-assistant-elser2"
    }
    }
}
}

You should see the test_index index in the Knowledge Base > New > Index > Index (dropdown).

Checklist

Delete any items that are not applicable to this PR.

@e40pud e40pud added release_note:fix v9.0.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Generative AI Security Generative AI backport:version Backport to applied version labels v8.17.0 v8.16.1 labels Nov 13, 2024
@e40pud e40pud self-assigned this Nov 13, 2024
@e40pud e40pud requested a review from a team as a code owner November 13, 2024 12:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

},
},
semantic_text: {
unmapped: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have too much mock data here that is superfluous. By changing mockData to the following, the tests still prove the fix:

const mockFieldCaps = {
  indices: [
    'gtr-1',
    'gtr-with-bug',
    'gtr-with-semantic-1',
    'metrics-endpoint.metadata_current_default',
    'search-elastic-security-docs',
  ],
  fields: {
    content: {
      semantic_text: {
        indices: ['gtr-with-semantic-1'],
      },
    },
    ai_embeddings: {
      semantic_text: {
        indices: ['gtr-with-bug', 'search-elastic-security-docs'],
      },
    },
    semantic_text: {
      semantic_text: {
        indices: ['search-elastic-security-docs'],
      },
    },
  },
};

Copy link
Contributor

@stephmilovic stephmilovic Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, webstorm is so slow. I see this messes up the type. Feel free to disregard. But maybe we can cut down on those indices

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I just copied mappings from my local kibana to make it as close as possible to real setup :-) Will simplify it though.

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @e40pud

@e40pud e40pud merged commit 5ab39e5 into elastic:main Nov 18, 2024
37 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11896662204

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 18, 2024
…under New Index Enter for Knowledge Base. (elastic#199610) (elastic#199990)

## Summary

This PR fixes the issue described here
elastic#199610 (comment)

In short, we do not show all indices with `semantic_text` fields. We
only show those which have `semantic_text` fields named `content`.

### Testing notes

Add the index with the `semantic_text` field by running this command in
dev tools:

```
PUT test_index
{
  "mappings": {
  "properties": {
    "attachment": {
      "properties": {
        "content": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        },
        "content_length": {
          "type": "long"
        },
        "content_type": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        },
        "format": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        },
        "language": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        }
      }
    },
    "content2": {
      "type": "semantic_text",
      "inference_id": "elastic-security-ai-assistant-elser2"
    }
    }
}
}
```

You should see the `test_index` index in the `Knowledge Base > New >
Index > Index (dropdown)`.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Steph Milovic <[email protected]>
(cherry picked from commit 5ab39e5)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 18, 2024
…under New Index Enter for Knowledge Base. (elastic#199610) (elastic#199990)

## Summary

This PR fixes the issue described here
elastic#199610 (comment)

In short, we do not show all indices with `semantic_text` fields. We
only show those which have `semantic_text` fields named `content`.

### Testing notes

Add the index with the `semantic_text` field by running this command in
dev tools:

```
PUT test_index
{
  "mappings": {
  "properties": {
    "attachment": {
      "properties": {
        "content": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        },
        "content_length": {
          "type": "long"
        },
        "content_type": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        },
        "format": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        },
        "language": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        }
      }
    },
    "content2": {
      "type": "semantic_text",
      "inference_id": "elastic-security-ai-assistant-elser2"
    }
    }
}
}
```

You should see the `test_index` index in the `Knowledge Base > New >
Index > Index (dropdown)`.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Steph Milovic <[email protected]>
(cherry picked from commit 5ab39e5)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jesuswr pushed a commit to jesuswr/kibana that referenced this pull request Nov 18, 2024
…under New Index Enter for Knowledge Base. (elastic#199610) (elastic#199990)

## Summary

This PR fixes the issue described here
elastic#199610 (comment)

In short, we do not show all indices with `semantic_text` fields. We
only show those which have `semantic_text` fields named `content`.

### Testing notes

Add the index with the `semantic_text` field by running this command in
dev tools:

```
PUT test_index
{
  "mappings": {
  "properties": {
    "attachment": {
      "properties": {
        "content": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        },
        "content_length": {
          "type": "long"
        },
        "content_type": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        },
        "format": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        },
        "language": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        }
      }
    },
    "content2": {
      "type": "semantic_text",
      "inference_id": "elastic-security-ai-assistant-elser2"
    }
    }
}
}
```

You should see the `test_index` index in the `Knowledge Base > New >
Index > Index (dropdown)`.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Steph Milovic <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 18, 2024
…pdown under New Index Enter for Knowledge Base. (#199610) (#199990) (#200609)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution] [Bug] Index Values are not available in dropdown
under New Index Enter for Knowledge Base. (#199610)
(#199990)](#199990)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T16:23:05Z","message":"[Security
Solution] [Bug] Index Values are not available in dropdown under New
Index Enter for Knowledge Base. (#199610) (#199990)\n\n##
Summary\r\n\r\nThis PR fixes the issue described
here\r\nhttps://github.com//issues/199610#issuecomment-2473393109\r\n\r\nIn
short, we do not show all indices with `semantic_text` fields.
We\r\nonly show those which have `semantic_text` fields named
`content`.\r\n\r\n### Testing notes\r\n\r\nAdd the index with the
`semantic_text` field by running this command in\r\ndev
tools:\r\n\r\n```\r\nPUT test_index\r\n{\r\n \"mappings\": {\r\n
\"properties\": {\r\n \"attachment\": {\r\n \"properties\": {\r\n
\"content\": {\r\n \"type\": \"text\",\r\n \"fields\": {\r\n
\"keyword\": {\r\n \"type\": \"keyword\",\r\n \"ignore_above\": 256\r\n
}\r\n }\r\n },\r\n \"content_length\": {\r\n \"type\": \"long\"\r\n
},\r\n \"content_type\": {\r\n \"type\": \"text\",\r\n \"fields\": {\r\n
\"keyword\": {\r\n \"type\": \"keyword\",\r\n \"ignore_above\": 256\r\n
}\r\n }\r\n },\r\n \"format\": {\r\n \"type\": \"text\",\r\n \"fields\":
{\r\n \"keyword\": {\r\n \"type\": \"keyword\",\r\n \"ignore_above\":
256\r\n }\r\n }\r\n },\r\n \"language\": {\r\n \"type\": \"text\",\r\n
\"fields\": {\r\n \"keyword\": {\r\n \"type\": \"keyword\",\r\n
\"ignore_above\": 256\r\n }\r\n }\r\n }\r\n }\r\n },\r\n \"content2\":
{\r\n \"type\": \"semantic_text\",\r\n \"inference_id\":
\"elastic-security-ai-assistant-elser2\"\r\n }\r\n
}\r\n}\r\n}\r\n```\r\n\r\nYou should see the `test_index` index in the
`Knowledge Base > New >\r\nIndex > Index (dropdown)`.\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Steph Milovic
<[email protected]>","sha":"5ab39e5a413f426da232723317786321a7d57fc7","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:
SecuritySolution","Team:Security Generative
AI","backport:version","v8.17.0","v8.16.1"],"title":"[Security Solution]
[Bug] Index Values are not available in dropdown under New Index Enter
for Knowledge Base.
(#199610)","number":199990,"url":"https://github.com/elastic/kibana/pull/199990","mergeCommit":{"message":"[Security
Solution] [Bug] Index Values are not available in dropdown under New
Index Enter for Knowledge Base. (#199610) (#199990)\n\n##
Summary\r\n\r\nThis PR fixes the issue described
here\r\nhttps://github.com//issues/199610#issuecomment-2473393109\r\n\r\nIn
short, we do not show all indices with `semantic_text` fields.
We\r\nonly show those which have `semantic_text` fields named
`content`.\r\n\r\n### Testing notes\r\n\r\nAdd the index with the
`semantic_text` field by running this command in\r\ndev
tools:\r\n\r\n```\r\nPUT test_index\r\n{\r\n \"mappings\": {\r\n
\"properties\": {\r\n \"attachment\": {\r\n \"properties\": {\r\n
\"content\": {\r\n \"type\": \"text\",\r\n \"fields\": {\r\n
\"keyword\": {\r\n \"type\": \"keyword\",\r\n \"ignore_above\": 256\r\n
}\r\n }\r\n },\r\n \"content_length\": {\r\n \"type\": \"long\"\r\n
},\r\n \"content_type\": {\r\n \"type\": \"text\",\r\n \"fields\": {\r\n
\"keyword\": {\r\n \"type\": \"keyword\",\r\n \"ignore_above\": 256\r\n
}\r\n }\r\n },\r\n \"format\": {\r\n \"type\": \"text\",\r\n \"fields\":
{\r\n \"keyword\": {\r\n \"type\": \"keyword\",\r\n \"ignore_above\":
256\r\n }\r\n }\r\n },\r\n \"language\": {\r\n \"type\": \"text\",\r\n
\"fields\": {\r\n \"keyword\": {\r\n \"type\": \"keyword\",\r\n
\"ignore_above\": 256\r\n }\r\n }\r\n }\r\n }\r\n },\r\n \"content2\":
{\r\n \"type\": \"semantic_text\",\r\n \"inference_id\":
\"elastic-security-ai-assistant-elser2\"\r\n }\r\n
}\r\n}\r\n}\r\n```\r\n\r\nYou should see the `test_index` index in the
`Knowledge Base > New >\r\nIndex > Index (dropdown)`.\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Steph Milovic
<[email protected]>","sha":"5ab39e5a413f426da232723317786321a7d57fc7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199990","number":199990,"mergeCommit":{"message":"[Security
Solution] [Bug] Index Values are not available in dropdown under New
Index Enter for Knowledge Base. (#199610) (#199990)\n\n##
Summary\r\n\r\nThis PR fixes the issue described
here\r\nhttps://github.com//issues/199610#issuecomment-2473393109\r\n\r\nIn
short, we do not show all indices with `semantic_text` fields.
We\r\nonly show those which have `semantic_text` fields named
`content`.\r\n\r\n### Testing notes\r\n\r\nAdd the index with the
`semantic_text` field by running this command in\r\ndev
tools:\r\n\r\n```\r\nPUT test_index\r\n{\r\n \"mappings\": {\r\n
\"properties\": {\r\n \"attachment\": {\r\n \"properties\": {\r\n
\"content\": {\r\n \"type\": \"text\",\r\n \"fields\": {\r\n
\"keyword\": {\r\n \"type\": \"keyword\",\r\n \"ignore_above\": 256\r\n
}\r\n }\r\n },\r\n \"content_length\": {\r\n \"type\": \"long\"\r\n
},\r\n \"content_type\": {\r\n \"type\": \"text\",\r\n \"fields\": {\r\n
\"keyword\": {\r\n \"type\": \"keyword\",\r\n \"ignore_above\": 256\r\n
}\r\n }\r\n },\r\n \"format\": {\r\n \"type\": \"text\",\r\n \"fields\":
{\r\n \"keyword\": {\r\n \"type\": \"keyword\",\r\n \"ignore_above\":
256\r\n }\r\n }\r\n },\r\n \"language\": {\r\n \"type\": \"text\",\r\n
\"fields\": {\r\n \"keyword\": {\r\n \"type\": \"keyword\",\r\n
\"ignore_above\": 256\r\n }\r\n }\r\n }\r\n }\r\n },\r\n \"content2\":
{\r\n \"type\": \"semantic_text\",\r\n \"inference_id\":
\"elastic-security-ai-assistant-elser2\"\r\n }\r\n
}\r\n}\r\n}\r\n```\r\n\r\nYou should see the `test_index` index in the
`Knowledge Base > New >\r\nIndex > Index (dropdown)`.\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Steph Milovic
<[email protected]>","sha":"5ab39e5a413f426da232723317786321a7d57fc7"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Ievgen Sorokopud <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 18, 2024
…opdown under New Index Enter for Knowledge Base. (#199610) (#199990) (#200608)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Security Solution] [Bug] Index Values are not available in dropdown
under New Index Enter for Knowledge Base. (#199610)
(#199990)](#199990)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T16:23:05Z","message":"[Security
Solution] [Bug] Index Values are not available in dropdown under New
Index Enter for Knowledge Base. (#199610) (#199990)\n\n##
Summary\r\n\r\nThis PR fixes the issue described
here\r\nhttps://github.com//issues/199610#issuecomment-2473393109\r\n\r\nIn
short, we do not show all indices with `semantic_text` fields.
We\r\nonly show those which have `semantic_text` fields named
`content`.\r\n\r\n### Testing notes\r\n\r\nAdd the index with the
`semantic_text` field by running this command in\r\ndev
tools:\r\n\r\n```\r\nPUT test_index\r\n{\r\n \"mappings\": {\r\n
\"properties\": {\r\n \"attachment\": {\r\n \"properties\": {\r\n
\"content\": {\r\n \"type\": \"text\",\r\n \"fields\": {\r\n
\"keyword\": {\r\n \"type\": \"keyword\",\r\n \"ignore_above\": 256\r\n
}\r\n }\r\n },\r\n \"content_length\": {\r\n \"type\": \"long\"\r\n
},\r\n \"content_type\": {\r\n \"type\": \"text\",\r\n \"fields\": {\r\n
\"keyword\": {\r\n \"type\": \"keyword\",\r\n \"ignore_above\": 256\r\n
}\r\n }\r\n },\r\n \"format\": {\r\n \"type\": \"text\",\r\n \"fields\":
{\r\n \"keyword\": {\r\n \"type\": \"keyword\",\r\n \"ignore_above\":
256\r\n }\r\n }\r\n },\r\n \"language\": {\r\n \"type\": \"text\",\r\n
\"fields\": {\r\n \"keyword\": {\r\n \"type\": \"keyword\",\r\n
\"ignore_above\": 256\r\n }\r\n }\r\n }\r\n }\r\n },\r\n \"content2\":
{\r\n \"type\": \"semantic_text\",\r\n \"inference_id\":
\"elastic-security-ai-assistant-elser2\"\r\n }\r\n
}\r\n}\r\n}\r\n```\r\n\r\nYou should see the `test_index` index in the
`Knowledge Base > New >\r\nIndex > Index (dropdown)`.\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Steph Milovic
<[email protected]>","sha":"5ab39e5a413f426da232723317786321a7d57fc7","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:
SecuritySolution","Team:Security Generative
AI","backport:version","v8.17.0","v8.16.1"],"title":"[Security Solution]
[Bug] Index Values are not available in dropdown under New Index Enter
for Knowledge Base.
(#199610)","number":199990,"url":"https://github.com/elastic/kibana/pull/199990","mergeCommit":{"message":"[Security
Solution] [Bug] Index Values are not available in dropdown under New
Index Enter for Knowledge Base. (#199610) (#199990)\n\n##
Summary\r\n\r\nThis PR fixes the issue described
here\r\nhttps://github.com//issues/199610#issuecomment-2473393109\r\n\r\nIn
short, we do not show all indices with `semantic_text` fields.
We\r\nonly show those which have `semantic_text` fields named
`content`.\r\n\r\n### Testing notes\r\n\r\nAdd the index with the
`semantic_text` field by running this command in\r\ndev
tools:\r\n\r\n```\r\nPUT test_index\r\n{\r\n \"mappings\": {\r\n
\"properties\": {\r\n \"attachment\": {\r\n \"properties\": {\r\n
\"content\": {\r\n \"type\": \"text\",\r\n \"fields\": {\r\n
\"keyword\": {\r\n \"type\": \"keyword\",\r\n \"ignore_above\": 256\r\n
}\r\n }\r\n },\r\n \"content_length\": {\r\n \"type\": \"long\"\r\n
},\r\n \"content_type\": {\r\n \"type\": \"text\",\r\n \"fields\": {\r\n
\"keyword\": {\r\n \"type\": \"keyword\",\r\n \"ignore_above\": 256\r\n
}\r\n }\r\n },\r\n \"format\": {\r\n \"type\": \"text\",\r\n \"fields\":
{\r\n \"keyword\": {\r\n \"type\": \"keyword\",\r\n \"ignore_above\":
256\r\n }\r\n }\r\n },\r\n \"language\": {\r\n \"type\": \"text\",\r\n
\"fields\": {\r\n \"keyword\": {\r\n \"type\": \"keyword\",\r\n
\"ignore_above\": 256\r\n }\r\n }\r\n }\r\n }\r\n },\r\n \"content2\":
{\r\n \"type\": \"semantic_text\",\r\n \"inference_id\":
\"elastic-security-ai-assistant-elser2\"\r\n }\r\n
}\r\n}\r\n}\r\n```\r\n\r\nYou should see the `test_index` index in the
`Knowledge Base > New >\r\nIndex > Index (dropdown)`.\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Steph Milovic
<[email protected]>","sha":"5ab39e5a413f426da232723317786321a7d57fc7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199990","number":199990,"mergeCommit":{"message":"[Security
Solution] [Bug] Index Values are not available in dropdown under New
Index Enter for Knowledge Base. (#199610) (#199990)\n\n##
Summary\r\n\r\nThis PR fixes the issue described
here\r\nhttps://github.com//issues/199610#issuecomment-2473393109\r\n\r\nIn
short, we do not show all indices with `semantic_text` fields.
We\r\nonly show those which have `semantic_text` fields named
`content`.\r\n\r\n### Testing notes\r\n\r\nAdd the index with the
`semantic_text` field by running this command in\r\ndev
tools:\r\n\r\n```\r\nPUT test_index\r\n{\r\n \"mappings\": {\r\n
\"properties\": {\r\n \"attachment\": {\r\n \"properties\": {\r\n
\"content\": {\r\n \"type\": \"text\",\r\n \"fields\": {\r\n
\"keyword\": {\r\n \"type\": \"keyword\",\r\n \"ignore_above\": 256\r\n
}\r\n }\r\n },\r\n \"content_length\": {\r\n \"type\": \"long\"\r\n
},\r\n \"content_type\": {\r\n \"type\": \"text\",\r\n \"fields\": {\r\n
\"keyword\": {\r\n \"type\": \"keyword\",\r\n \"ignore_above\": 256\r\n
}\r\n }\r\n },\r\n \"format\": {\r\n \"type\": \"text\",\r\n \"fields\":
{\r\n \"keyword\": {\r\n \"type\": \"keyword\",\r\n \"ignore_above\":
256\r\n }\r\n }\r\n },\r\n \"language\": {\r\n \"type\": \"text\",\r\n
\"fields\": {\r\n \"keyword\": {\r\n \"type\": \"keyword\",\r\n
\"ignore_above\": 256\r\n }\r\n }\r\n }\r\n }\r\n },\r\n \"content2\":
{\r\n \"type\": \"semantic_text\",\r\n \"inference_id\":
\"elastic-security-ai-assistant-elser2\"\r\n }\r\n
}\r\n}\r\n}\r\n```\r\n\r\nYou should see the `test_index` index in the
`Knowledge Base > New >\r\nIndex > Index (dropdown)`.\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Steph Milovic
<[email protected]>","sha":"5ab39e5a413f426da232723317786321a7d57fc7"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Ievgen Sorokopud <[email protected]>
@muskangulati-qasource
Copy link

Hi @MadameSheema,

We have tested this ticket on the latest 8.16.1 BC2 and found the issue is now fixed.

Please find below the testing details:

Build details

VERSION: 8.16.1
BUILD: 79724
COMMIT: c8b46e87c4d61de4fe046ce5ea0a0b68aad5acf9

Screenshots

  • The index is created successfully
    Image

  • The same index is visible under the drop down
    Image

  • The index is used and entry is created successfully
    Image

Thanks!!

@muskangulati-qasource muskangulati-qasource added the QA:Validated Issue has been validated by QA label Nov 20, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
…under New Index Enter for Knowledge Base. (elastic#199610) (elastic#199990)

## Summary

This PR fixes the issue described here
elastic#199610 (comment)

In short, we do not show all indices with `semantic_text` fields. We
only show those which have `semantic_text` fields named `content`.

### Testing notes

Add the index with the `semantic_text` field by running this command in
dev tools:

```
PUT test_index
{
  "mappings": {
  "properties": {
    "attachment": {
      "properties": {
        "content": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        },
        "content_length": {
          "type": "long"
        },
        "content_type": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        },
        "format": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        },
        "language": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        }
      }
    },
    "content2": {
      "type": "semantic_text",
      "inference_id": "elastic-security-ai-assistant-elser2"
    }
    }
}
}
```

You should see the `test_index` index in the `Knowledge Base > New >
Index > Index (dropdown)`.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Steph Milovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels QA:Validated Issue has been validated by QA release_note:fix Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.1 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants