Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automatic Import] Fix the enter bug #199894

Merged
merged 25 commits into from
Dec 11, 2024
Merged

[Automatic Import] Fix the enter bug #199894

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
3840ad5
Fix the enter bug
ilyannn Nov 8, 2024
c48c76a
Move up the logic of completeStep
ilyannn Nov 13, 2024
09d943a
Fix the close button bug
ilyannn Nov 13, 2024
c99de53
Merge branch 'main' into auto-import/form-submit-fixes
elasticmachine Nov 13, 2024
60af1de
Merge branch 'main' of github.com:elastic/kibana into auto-import/for…
ilyannn Nov 25, 2024
a215cc7
Merge branch 'auto-import/form-submit-fixes' of github.com:ilyannn/ki…
ilyannn Nov 25, 2024
feb0b72
Make stuff easier to test
ilyannn Nov 25, 2024
69ec953
Move step 1 tests to create_integration_assistant.test.tsx
ilyannn Nov 25, 2024
65497d3
Rename ...StepReady to ...StepCompleted
ilyannn Nov 25, 2024
0aa6007
Fill out the rest of the tests
ilyannn Nov 26, 2024
f90b49f
Fix the test when there are two Next buttons
ilyannn Nov 26, 2024
76811a9
Merge branch 'main' into auto-import/form-submit-fixes
ilyannn Nov 26, 2024
37aa33b
Revert an accidental rename
ilyannn Nov 26, 2024
27e1ff3
Remove commented out things
ilyannn Nov 26, 2024
7456753
Allow for the possibiliy of an unknown step
ilyannn Nov 26, 2024
b395639
Update the Cypress test
ilyannn Dec 6, 2024
ea78042
Merge branch 'main' into auto-import/form-submit-fixes
ilyannn Dec 6, 2024
18e6b94
Merge branch 'main' into auto-import/form-submit-fixes
ilyannn Dec 8, 2024
413db06
Merge branch 'main' into auto-import/form-submit-fixes
ilyannn Dec 9, 2024
11729a8
Merge branch 'main' into auto-import/form-submit-fixes
ilyannn Dec 10, 2024
ff4de18
Implement review feedback
ilyannn Dec 10, 2024
78192c7
Fix the button identifier
ilyannn Dec 10, 2024
a99a987
Merge branch 'main' into auto-import/form-submit-fixes
ilyannn Dec 11, 2024
a014966
Revert the Cypress test for now
ilyannn Dec 11, 2024
21df245
Revert the Cypress part further
ilyannn Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/plugins/fleet/cypress/e2e/integrations_automatic_import.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@ describe('Add Integration - Automatic Import', () => {
cy.getBySel(BUTTON_FOOTER_NEXT).click();

// Integration details Page
cy.getBySel(INTEGRATION_TITLE_INPUT).type('Test Integration');
cy.getBySel(INTEGRATION_DESCRIPTION_INPUT).type('Test Integration Description');
cy.getBySel(BUTTON_FOOTER_NEXT).click();
cy.getBySel(INTEGRATION_TITLE_INPUT).type('Test Integration\n');
// Pressing Enter key in a single-line input should move to the next step.
bhapas marked this conversation as resolved.
Show resolved Hide resolved

// Datastream details page
cy.getBySel(DATASTREAM_TITLE_INPUT).type('Audit');
Expand Down
Loading