Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset Quality] Show dataset quality in details page #199890

Conversation

mohamedhamed-ahmed
Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed commented Nov 13, 2024

closes #197800

📝 Summary

This PR add a new UI representation for the Dataset Quality in the Details page.

🎥 Demo

Screen.Recording.2024-11-13.at.12.28.52.mov

@mohamedhamed-ahmed mohamedhamed-ahmed added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 13, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
datasetQuality 251.2KB 251.4KB +212.0B

@mohamedhamed-ahmed mohamedhamed-ahmed added the Team:obs-ux-logs Observability Logs User Experience Team label Nov 13, 2024
@mohamedhamed-ahmed mohamedhamed-ahmed marked this pull request as ready for review November 13, 2024 11:30
@mohamedhamed-ahmed mohamedhamed-ahmed requested a review from a team as a code owner November 13, 2024 11:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤩

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 13, 2024
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mohamedhamed-ahmed mohamedhamed-ahmed merged commit 5dc30e7 into elastic:main Nov 13, 2024
31 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11816670464

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 13, 2024
closes elastic#197800

## 📝  Summary

This PR add a new UI representation for the Dataset Quality in the
Details page.

## 🎥 Demo

https://github.com/user-attachments/assets/e0860fa3-cb82-44ef-bfb5-e8dcb00100f1
(cherry picked from commit 5dc30e7)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 13, 2024
#199987)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Dataset Quality] Show dataset quality in details page
(#199890)](#199890)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"mohamedhamed-ahmed","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T11:51:28Z","message":"[Dataset
Quality] Show dataset quality in details page (#199890)\n\ncloses
https://github.com/elastic/kibana/issues/197800\r\n\r\n\r\n## 📝
Summary\r\n\r\nThis PR add a new UI representation for the Dataset
Quality in the\r\nDetails page.\r\n\r\n## 🎥
Demo\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e0860fa3-cb82-44ef-bfb5-e8dcb00100f1","sha":"5dc30e775131e4768fdef48b8b31f735e7b26df2","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs"],"title":"[Dataset
Quality] Show dataset quality in details
page","number":199890,"url":"https://github.com/elastic/kibana/pull/199890","mergeCommit":{"message":"[Dataset
Quality] Show dataset quality in details page (#199890)\n\ncloses
https://github.com/elastic/kibana/issues/197800\r\n\r\n\r\n## 📝
Summary\r\n\r\nThis PR add a new UI representation for the Dataset
Quality in the\r\nDetails page.\r\n\r\n## 🎥
Demo\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e0860fa3-cb82-44ef-bfb5-e8dcb00100f1","sha":"5dc30e775131e4768fdef48b8b31f735e7b26df2"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199890","number":199890,"mergeCommit":{"message":"[Dataset
Quality] Show dataset quality in details page (#199890)\n\ncloses
https://github.com/elastic/kibana/issues/197800\r\n\r\n\r\n## 📝
Summary\r\n\r\nThis PR add a new UI representation for the Dataset
Quality in the\r\nDetails page.\r\n\r\n## 🎥
Demo\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e0860fa3-cb82-44ef-bfb5-e8dcb00100f1","sha":"5dc30e775131e4768fdef48b8b31f735e7b26df2"}}]}]
BACKPORT-->

Co-authored-by: mohamedhamed-ahmed <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
closes elastic#197800


## 📝  Summary

This PR add a new UI representation for the Dataset Quality in the
Details page.

## 🎥 Demo


https://github.com/user-attachments/assets/e0860fa3-cb82-44ef-bfb5-e8dcb00100f1
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
closes elastic#197800


## 📝  Summary

This PR add a new UI representation for the Dataset Quality in the
Details page.

## 🎥 Demo


https://github.com/user-attachments/assets/e0860fa3-cb82-44ef-bfb5-e8dcb00100f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dataset quality] Current quality status in dataset details
4 participants