Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Obs AI Assistant] Remove the copy button if there is no content to copy (#199064) #199874

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…opy (elastic#199064)

Closes elastic#196986

## Summary

### Problem
The copy button for a visualization does nothing, as there's no content
to copy. When clicked on this button, a message is shown saying "Copied
Message", but nothing is copied.

### Solution
Remove the copy button, when there's no content to copy.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit a613277)
@kibanamachine kibanamachine merged commit c938f31 into elastic:8.x Nov 12, 2024
24 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAIAssistantApp 239.2KB 239.2KB +3.0B
searchAssistant 162.0KB 162.0KB +3.0B
total +6.0B

cc @viduni94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants