-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mappings Editor] Add support for synthetic _source #199854
Merged
ElenaStoeva
merged 23 commits into
elastic:main
from
ElenaStoeva:mappings-configuration/source-field
Nov 19, 2024
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
96ec5ac
[Mappings Editor] Add support for synthetic _source
ElenaStoeva de0be81
Fix deserialization
ElenaStoeva 853f9ff
Fix error in component template form mappings editor
ElenaStoeva 92adc29
Fix existing jest tests
ElenaStoeva 32d6672
Add jest tests
ElenaStoeva 9fedad6
Merge branch 'main' into mappings-configuration/source-field
ElenaStoeva 16566e4
Fix copy
ElenaStoeva 991cb4f
[CI] Auto-commit changed files from 'make api-docs'
kibanamachine b485c9a
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine a131400
Fix _source field value change when index mode is logsdb
ElenaStoeva fc5c998
Merge branch 'mappings-configuration/source-field' of https://github.…
ElenaStoeva aa2b19b
Fix typo in copy
ElenaStoeva 772ede9
Fix i18n errors
ElenaStoeva a8ae5d6
Fix jest tests
ElenaStoeva fbe99d4
Merge branch 'main' into mappings-configuration/source-field
ElenaStoeva 6c7e5c5
Refactor changes
ElenaStoeva 57624e1
Merge branch 'mappings-configuration/source-field' of https://github.…
ElenaStoeva 0c70fce
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine 1c8422a
Fix type errors
ElenaStoeva 117ec85
Fix merge conflicts
ElenaStoeva 1907323
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine 4b89cac
Fix jest tests
ElenaStoeva 12d3b27
Add serialization tests
ElenaStoeva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: It might just be me, but this seems a little too complex to read at first glance. Perhaps a more explicit structure could make future extensions more straightforward? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally understand! I did my best to make it as clear as possible but it's a bit tricky given that the
sourceField.option
field actually controls two properties in Es (mode
andenabled
). We also don't want to add themode
property if the field is undefined (which means it hasn't been set by the user) - otherwise, just opening the "Advanced options" tab would insert a "mode" property which is a behavior that we recently managed to fix in this form. I'm open to any suggestions for shortening/simplifying the code.