Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [IndexAdapter] Extract index-adapter package from data-stream-adapter (#199575) #199848

Merged
merged 2 commits into from
Nov 12, 2024
Merged

[8.x] [IndexAdapter] Extract index-adapter package from data-stream-adapter (#199575) #199848

merged 2 commits into from
Nov 12, 2024

Conversation

semd
Copy link
Contributor

@semd semd commented Nov 12, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@semd
[IndexAdapter] Extract index-adapter package from data-stream-adapter (…
e992270 
…elastic#199575)

## Summary

Extracts `IndexAdapter` from `DataStreamAdapter` and
`IndexPatternAdapter` from `DataStreamSpaceAdapter`.

There are no breaking changes for the _data-stream-adapter_ package; the
behavior of both the `DataStreamAdapter` and `DataStreamSpaceAdapter`
remains unchanged.

The new _index-adapter_ package exports `IndexAdapter` and
`IndexPatternAdapter` to manage individual indices without using data
streams.

This is needed for SIEM rule migrations.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 9a9f02c)

# Conflicts:
#	.github/CODEOWNERS
#	package.json
#	tsconfig.base.json
#	yarn.lock
@semd semd added the backport label Nov 12, 2024
@semd semd enabled auto-merge (squash) November 12, 2024 18:04
@semd semd mentioned this pull request Nov 12, 2024
Merged
@kapral18 kapral18 self-requested a review November 12, 2024 18:34
kapral18
kapral18 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@kapral18 kapral18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@semd semd merged commit 953bc0f into elastic:8.x Nov 12, 2024
29 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/data-stream-adapter 80 54 -26
@kbn/index-adapter - 80 +80
total +54

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/data-stream-adapter 1 0 -1
@kbn/index-adapter - 2 +2
total +1
Unknown metric groups

API count

id before after diff
@kbn/data-stream-adapter 80 55 -25
@kbn/index-adapter - 85 +85
total +60

ESLint disabled line counts

id before after diff
@kbn/data-stream-adapter 2 0 -2
@kbn/index-adapter - 2 +2
total -0

Total ESLint disabled count

id before after diff
@kbn/data-stream-adapter 2 0 -2
@kbn/index-adapter - 2 +2
total -0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapral18 kapral18 kapral18 approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@semd @elasticmachine @kapral18