Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] Populate service.name for custom logs as part of auto-detect flow #199827

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

thomheymann
Copy link
Contributor

@thomheymann thomheymann commented Nov 12, 2024

Resolves https://github.com/elastic/observability-dev/issues/4038

Summary

Populate service.name for custom logs as part of auto-detect flow

Screenshot

Screenshot 2024-11-12 at 17 10 29

@thomheymann thomheymann added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 12, 2024
@thomheymann thomheymann marked this pull request as ready for review November 12, 2024 22:13
@thomheymann thomheymann requested a review from a team as a code owner November 12, 2024 22:13
@thomheymann thomheymann requested a review from a team November 12, 2024 22:13
Copy link
Contributor

@mykolaharmash mykolaharmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 13, 2024
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@thomheymann thomheymann merged commit 4ba25f2 into elastic:main Nov 13, 2024
31 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11820451716

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Observability Onboarding] Display next steps (#197179)

Manual backport

To create the backport manually run:

node scripts/backport --pr 199827

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 199827 locally

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 14, 2024
thomheymann added a commit to thomheymann/kibana that referenced this pull request Nov 14, 2024
…-detect flow (elastic#199827)

Resolves elastic/observability-dev#4038

## Summary

Populate service.name for custom logs as part of auto-detect flow

## Screenshot

<img width="705" alt="Screenshot 2024-11-12 at 17 10 29"
src="https://github.com/user-attachments/assets/2eeb846c-9006-4252-81a0-ea5d4b5cdb8b">

(cherry picked from commit 4ba25f2)
@thomheymann
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

thomheymann added a commit that referenced this pull request Nov 18, 2024
…f auto-detect flow (#199827) (#200234)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Observability] Populate service.name for custom logs as part of
auto-detect flow
(#199827)](#199827)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Thom
Heymann","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T15:28:44Z","message":"[Observability]
Populate service.name for custom logs as part of auto-detect flow
(#199827)\n\nResolves
https://github.com/elastic/observability-dev/issues/4038\r\n\r\n##
Summary\r\n\r\nPopulate service.name for custom logs as part of
auto-detect flow\r\n\r\n## Screenshot\r\n\r\n<img width=\"705\"
alt=\"Screenshot 2024-11-12 at 17 10
29\"\r\nsrc=\"https://github.com/user-attachments/assets/2eeb846c-9006-4252-81a0-ea5d4b5cdb8b\">","sha":"4ba25f211ab6fa8d256d6385583b1ad6f2868717","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","v9.0.0","backport:prev-minor","ci:project-deploy-observability"],"number":199827,"url":"https://github.com/elastic/kibana/pull/199827","mergeCommit":{"message":"[Observability]
Populate service.name for custom logs as part of auto-detect flow
(#199827)\n\nResolves
https://github.com/elastic/observability-dev/issues/4038\r\n\r\n##
Summary\r\n\r\nPopulate service.name for custom logs as part of
auto-detect flow\r\n\r\n## Screenshot\r\n\r\n<img width=\"705\"
alt=\"Screenshot 2024-11-12 at 17 10
29\"\r\nsrc=\"https://github.com/user-attachments/assets/2eeb846c-9006-4252-81a0-ea5d4b5cdb8b\">","sha":"4ba25f211ab6fa8d256d6385583b1ad6f2868717"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199827","number":199827,"mergeCommit":{"message":"[Observability]
Populate service.name for custom logs as part of auto-detect flow
(#199827)\n\nResolves
https://github.com/elastic/observability-dev/issues/4038\r\n\r\n##
Summary\r\n\r\nPopulate service.name for custom logs as part of
auto-detect flow\r\n\r\n## Screenshot\r\n\r\n<img width=\"705\"
alt=\"Screenshot 2024-11-12 at 17 10
29\"\r\nsrc=\"https://github.com/user-attachments/assets/2eeb846c-9006-4252-81a0-ea5d4b5cdb8b\">","sha":"4ba25f211ab6fa8d256d6385583b1ad6f2868717"}}]}]
BACKPORT-->
@kibanamachine kibanamachine added v8.17.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 18, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
…-detect flow (elastic#199827)

Resolves elastic/observability-dev#4038

## Summary

Populate service.name for custom logs as part of auto-detect flow

## Screenshot

<img width="705" alt="Screenshot 2024-11-12 at 17 10 29"
src="https://github.com/user-attachments/assets/2eeb846c-9006-4252-81a0-ea5d4b5cdb8b">
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
…-detect flow (elastic#199827)

Resolves elastic/observability-dev#4038

## Summary

Populate service.name for custom logs as part of auto-detect flow

## Screenshot

<img width="705" alt="Screenshot 2024-11-12 at 17 10 29"
src="https://github.com/user-attachments/assets/2eeb846c-9006-4252-81a0-ea5d4b5cdb8b">
@flash1293
Copy link
Contributor

@thomheymann do we still need to backport this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants