[APM] Migrate /observability_overview to deployment agnostic test
#199817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
rmyz
commented
Nov 12, 2024
|
|
||
| describe('when data is loaded', () => { | ||
| before(async () => { | ||
| await esArchiver.load(ARCHIVER_ROUTES['8.0.0']); |
There was a problem hiding this comment.
Using 8.0.0 as apm_8.0.0 contains .ml-config indices which make MKI unable to pass. The logic stills the same as this endpoint only checks if there is any apm data, and there is.
There was a problem hiding this comment.
Thanks for mentioning this! I’ll double-check a few migration issues I previously discarded for similar reasons to see if that change might allow them to work without the ML index on the mappings.
rmyz
commented
Nov 12, 2024
| @@ -6213,10 +6213,6 @@ | |||
| "read_only_allow_delete": "false" | |||
| }, | |||
| "codec": "best_compression", | |||
There was a problem hiding this comment.
Removed lifecycle and refresh_interval on both archives as they crash for serverless & MKI
There was a problem hiding this comment.
How do we know that removing the refresh_interval won’t affect any other tests?
There was a problem hiding this comment.
as @crespocarlos said, it should pick up the default value and not give any problems, at least, I did that before and nothing happened
rmyz
added
backport:skip
|
Running flaky test runner as I removed a comment |
rmyz
changed the title
/environment to deployment agnostic test/observability_overview to deployment agnostic test
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7387[✅] x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts: 25/25 tests passed. |
# Conflicts: # x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/index.ts
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
iblancof
approved these changes
Nov 13, 2024
# Conflicts: # x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/index.ts
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @rmyz |
crespocarlos
approved these changes
Nov 13, 2024
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 13, 2024
…lastic#199817) ## Summary Closes elastic#198981 Part of elastic#193245 This PR contains the changes to migrate `observability_overview` test folder to Deployment-agnostic testing strategy. ### How to test - Serverless ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM" ``` It's recommended to be run against [MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki) - Stateful ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM" ``` ## Checks - [x] (OPTIONAL, only if a test has been unskipped) Run flaky test suite - [x] local run for serverless - [x] local run for stateful - [x] MKI run for serverless (cherry picked from commit 7a61d10)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 13, 2024
… agnostic test (#199817) (#200012) # Backport This will backport the following commits from `main` to `8.x`: - [[APM] Migrate `/observability_overview` to deployment agnostic test (#199817)](#199817) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T14:21:54Z","message":"[APM] Migrate `/observability_overview` to deployment agnostic test (#199817)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/198981\nPart of https://github.com/elastic/kibana/issues/193245\n\nThis PR contains the changes to migrate `observability_overview` test\nfolder to Deployment-agnostic testing strategy.\n\n### How to test\n\n- Serverless\n\n```\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep=\"APM\"\n```\n\nIt's recommended to be run against\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\n\n- Stateful\n```\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep=\"APM\"\n```\n\n## Checks\n\n- [x] (OPTIONAL, only if a test has been unskipped) Run flaky test suite\n- [x] local run for serverless\n- [x] local run for stateful\n- [x] MKI run for serverless","sha":"7a61d10eef804f3695071969116bbe64afd864b6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","apm","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"[APM] Migrate `/observability_overview` to deployment agnostic test","number":199817,"url":"https://github.com/elastic/kibana/pull/199817","mergeCommit":{"message":"[APM] Migrate `/observability_overview` to deployment agnostic test (#199817)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/198981\nPart of https://github.com/elastic/kibana/issues/193245\n\nThis PR contains the changes to migrate `observability_overview` test\nfolder to Deployment-agnostic testing strategy.\n\n### How to test\n\n- Serverless\n\n```\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep=\"APM\"\n```\n\nIt's recommended to be run against\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\n\n- Stateful\n```\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep=\"APM\"\n```\n\n## Checks\n\n- [x] (OPTIONAL, only if a test has been unskipped) Run flaky test suite\n- [x] local run for serverless\n- [x] local run for stateful\n- [x] MKI run for serverless","sha":"7a61d10eef804f3695071969116bbe64afd864b6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199817","number":199817,"mergeCommit":{"message":"[APM] Migrate `/observability_overview` to deployment agnostic test (#199817)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/198981\nPart of https://github.com/elastic/kibana/issues/193245\n\nThis PR contains the changes to migrate `observability_overview` test\nfolder to Deployment-agnostic testing strategy.\n\n### How to test\n\n- Serverless\n\n```\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep=\"APM\"\n```\n\nIt's recommended to be run against\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\n\n- Stateful\n```\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep=\"APM\"\n```\n\n## Checks\n\n- [x] (OPTIONAL, only if a test has been unskipped) Run flaky test suite\n- [x] local run for serverless\n- [x] local run for stateful\n- [x] MKI run for serverless","sha":"7a61d10eef804f3695071969116bbe64afd864b6"}}]}] BACKPORT--> Co-authored-by: Sergi Romeu <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
…lastic#199817) ## Summary Closes elastic#198981 Part of elastic#193245 This PR contains the changes to migrate `observability_overview` test folder to Deployment-agnostic testing strategy. ### How to test - Serverless ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM" ``` It's recommended to be run against [MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki) - Stateful ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM" ``` ## Checks - [x] (OPTIONAL, only if a test has been unskipped) Run flaky test suite - [x] local run for serverless - [x] local run for stateful - [x] MKI run for serverless
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
…lastic#199817) ## Summary Closes elastic#198981 Part of elastic#193245 This PR contains the changes to migrate `observability_overview` test folder to Deployment-agnostic testing strategy. ### How to test - Serverless ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM" ``` It's recommended to be run against [MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki) - Stateful ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM" ``` ## Checks - [x] (OPTIONAL, only if a test has been unskipped) Run flaky test suite - [x] local run for serverless - [x] local run for stateful - [x] MKI run for serverless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #198981
Part of #193245
This PR contains the changes to migrate
observability_overviewtest folder to Deployment-agnostic testing strategy.How to test
It's recommended to be run against MKI
Checks