-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for experimental theme switching #199748
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
8d4b0f7
feat: add basic support for experimental theme switching
tkajtoch 0bb04e8
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine e510604
update tests and mocks to account for the new `name` property
tkajtoch b521f53
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine c8d090c
fix failing bootstrap_renderer tests due to now incorrect UI settings…
tkajtoch 6e85833
add `theme:name` to stack telemetry collectors
tkajtoch e385ad2
add theme utilities to core-ui-settings-common and refactor theme loa…
tkajtoch 591948f
eslint fix
tkajtoch e1ae606
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine 591bc4a
fix test assertions
tkajtoch 7b518a3
Merge branch 'main' into feat/eui-theming
clintandrewhall ac0c7b6
fix `theme_loader` to only include the fallback `default` switch clau…
tkajtoch c9bc309
Update packages/core/rendering/core-rendering-server-internal/src/boo…
tkajtoch 08efdfb
Update packages/core/rendering/core-rendering-server-internal/src/boo…
tkajtoch 544b270
add `@kbn/react-kibana-context-theme` to shared deps
tkajtoch deab885
increase aiops optimizer limits slightly
tkajtoch 38364d2
Revert "add `@kbn/react-kibana-context-theme` to shared deps"
tkajtoch a4391ca
Revert "Revert "add `@kbn/react-kibana-context-theme` to shared deps""
tkajtoch 9d8c8f6
update type of `@kbn/react-kibana-context-theme` to `shared-common` s…
tkajtoch 84b20c7
update type of `@kbn/react-kibana-context-root` and `@kbn/react-kiban…
tkajtoch d721304
Merge remote-tracking branch 'upstream/main' into feat/eui-theming
tkajtoch e69f313
[CI] Auto-commit changed files from 'make api-docs'
kibanamachine 7b0a622
Merge branch 'main' into feat/eui-theming
elasticmachine 069b07e
Merge branch 'main' into feat/eui-theming
elasticmachine 7882da6
Merge branch 'main' into feat/eui-theming
mistic 4b791f0
Merge branch 'main' into feat/eui-theming
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
load("@build_bazel_rules_nodejs//:index.bzl", "js_library") | ||
|
||
SRCS = glob( | ||
[ | ||
"**/*.ts", | ||
"**/*.tsx", | ||
], | ||
exclude = [ | ||
"**/test_helpers.ts", | ||
"**/*.config.js", | ||
"**/*.mock.*", | ||
"**/*.test.*", | ||
"**/*.stories.*", | ||
"**/__snapshots__/**", | ||
"**/integration_tests/**", | ||
"**/mocks/**", | ||
"**/scripts/**", | ||
"**/storybook/**", | ||
"**/test_fixtures/**", | ||
"**/test_helpers/**", | ||
], | ||
) | ||
|
||
DEPS = [ | ||
"@npm//react", | ||
"@npm//tslib", | ||
] | ||
|
||
js_library( | ||
name = "core-base-common", | ||
package_name = "@kbn/core-base-common", | ||
srcs = ["package.json"] + SRCS, | ||
deps = DEPS, | ||
visibility = ["//visibility:public"], | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
...rendering/core-rendering-server-internal/src/__snapshots__/rendering_service.test.ts.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so is v8 still the default theme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct,
v8
is the theme tag of what kibana ships with right now, and we call it Amsterdam. Up to this point themes were versioned by kibana majors and not named, that's why we have thev8
theme (and before that we had thev7
theme) but that's not what we want to do moving forward.The updated approach is to differentiate themes by their name resulting in theme tags like
borealislight
andborealisdark
for the new Borealis theme. For compatibility reasons we decided to keep the theme tags for the current Amsterdam theme the same, sov8light
andv8dark
, and that's why that specific mapping ofamsterdam
theme name tov8
is necessary.