Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Search][Connectors][a11y] Fixing wrong navigation sequence after closing Manual configuration dialog (#199613) #199740

Merged
merged 1 commit into from
Nov 12, 2024
Merged

[8.x] [Search][Connectors][a11y] Fixing wrong navigation sequence after closing Manual configuration dialog (#199613) #199740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...search_content/components/connectors/create_connector/components/manual_configuration.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,6 @@ GET connector-${rawName}/_search
onClick={() => {
setFlyoutContent('manual_config');
setIsFlyoutVisible(true);
closePopover();
}}
>
{i18n.translate(
Expand Down Expand Up @@ -206,7 +205,6 @@ GET connector-${rawName}/_search
onClick={() => {
setFlyoutContent('client');
setIsFlyoutVisible(true);
closePopover();
}}
>
{i18n.translate(
Expand Down
6 changes: 5 additions & 1 deletion ...content/components/connectors/create_connector/components/manual_configuration_flyout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import {
EuiSpacer,
EuiText,
EuiTitle,
useEuiTheme,
useGeneratedHtmlId,
} from '@elastic/eui';
import { i18n } from '@kbn/i18n';
Expand Down Expand Up @@ -68,13 +69,16 @@ export const ManualConfigurationFlyout: React.FC<ManualConfigurationFlyoutProps>

const { connectorName } = useValues(NewConnectorLogic);
const { setRawName, createConnector } = useActions(NewConnectorLogic);

const { euiTheme } = useEuiTheme();
return (
<EuiFlyout
ownFocus
onClose={() => setIsFlyoutVisible(false)}
aria-labelledby={simpleFlyoutTitleId}
size="s"
// This fixes an a11y issue where the flyout was rendered below the Popover
// Now we let get the focus back to the Popover is we close the Flyout
maskProps={{ style: `z-index: ${Number(euiTheme.levels.menu) + 1}` }}
>
{flyoutContent === 'manual_config' && (
<>
Expand Down