Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset Quality] Fix privileges test timeout #199657

Merged
merged 2 commits into from
Nov 11, 2024
Merged

[Dataset Quality] Fix privileges test timeout #199657

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08e5b75
[Dataset Quality] Fix timeout with privileges test
mohamedhamed-ahmed Nov 11, 2024
a46ca34
[Dataset Quality] Fix privileges test timeout
mohamedhamed-ahmed Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions x-pack/test/functional/apps/dataset_quality/dataset_quality_privileges.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
const security = getService('security');
const synthtrace = getService('logSynthtraceEsClient');
const testSubjects = getService('testSubjects');
const retry = getService('retry');

const to = new Date(new Date().setDate(new Date().getDate() - 1)).toISOString();

const apacheAccessDatasetName = 'apache.access';
Expand Down Expand Up @@ -144,15 +146,16 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
const datasetWithMonitorPrivilege = apacheAccessDatasetHumanName;
const datasetWithoutMonitorPrivilege = 'synth.1';

// "Size" should be available for `apacheAccessDatasetName`
await testSubjects.missingOrFail(
`${PageObjects.datasetQuality.testSubjectSelectors.datasetQualityInsufficientPrivileges}-sizeBytes-${datasetWithMonitorPrivilege}`
);

// "Size" should not be available for `datasetWithoutMonitorPrivilege`
await testSubjects.existOrFail(
`${PageObjects.datasetQuality.testSubjectSelectors.datasetQualityInsufficientPrivileges}-sizeBytes-${datasetWithoutMonitorPrivilege}`
);
await retry.tryForTime(5000, async () => {
// "Size" should be available for `apacheAccessDatasetName`
await testSubjects.missingOrFail(
`${PageObjects.datasetQuality.testSubjectSelectors.datasetQualityInsufficientPrivileges}-sizeBytes-${datasetWithMonitorPrivilege}`
);
// "Size" should not be available for `datasetWithoutMonitorPrivilege`
await testSubjects.existOrFail(
`${PageObjects.datasetQuality.testSubjectSelectors.datasetQualityInsufficientPrivileges}-sizeBytes-${datasetWithoutMonitorPrivilege}`
);
});
});

it('Details page shows insufficient privileges warning for underprivileged data stream', async () => {
Expand Down