[SecuritySolution] Improve asset criticality bulk error when entities are duplicated #199651
+116
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It also fixes server errors line to be '1' based.
machadoum
added
v9.0.0
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
|
@machadoum could you compare the time taken uploading a very big file before and after the duplication detection change? |
hop-dev
reviewed
Nov 11, 2024
...rity_solution/server/lib/entity_analytics/asset_criticality/asset_criticality_data_client.ts
Outdated
Show resolved
Hide resolved
hop-dev
requested changes
Nov 11, 2024
|
Starting backport for target branches: 8.x |
💚 Build Succeeded
Metrics [docs]
History
cc @machadoum |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 13, 2024
… are duplicated (elastic#199651) ## Summary * Improve asset criticality bulk error when entities are duplicated * It also fixes the server errors line to be '1' based.  ### Performance Test parameters: file with +33k lines and ~1 MB size. * Before 6.24 seconds * After 6.46 seconds Execution time Increased ~0.22 seconds ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 02ac5fc)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
machadoum
added a commit
to machadoum/kibana
that referenced
this pull request
Nov 13, 2024
… are duplicated (elastic#199651) ## Summary * Improve asset criticality bulk error when entities are duplicated * It also fixes the server errors line to be '1' based.  ### Performance Test parameters: file with +33k lines and ~1 MB size. * Before 6.24 seconds * After 6.46 seconds Execution time Increased ~0.22 seconds ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 02ac5fc)
kibanamachine
added a commit
that referenced
this pull request
Nov 13, 2024
…tities are duplicated (#199651) (#199968) # Backport This will backport the following commits from `main` to `8.x`: - [[SecuritySolution] Improve asset criticality bulk error when entities are duplicated (#199651)](#199651) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Pablo Machado","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T10:22:44Z","message":"[SecuritySolution] Improve asset criticality bulk error when entities are duplicated (#199651)\n\n## Summary\r\n\r\n* Improve asset criticality bulk error when entities are duplicated\r\n* It also fixes the server errors line to be '1' based.\r\n\r\n\r\n\r\n### Performance\r\n\r\nTest parameters: file with +33k lines and ~1 MB size.\r\n* Before 6.24 seconds\r\n* After 6.46 seconds\r\n\r\nExecution time Increased ~0.22 seconds\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"02ac5fc90f08615d877befc05f9675838ade77b4","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","Team: SecuritySolution","Theme: entity_analytics","Feature:Entity Analytics","Team:Entity Analytics","backport:version","v8.17.0"],"title":"[SecuritySolution] Improve asset criticality bulk error when entities are duplicated","number":199651,"url":"https://github.com/elastic/kibana/pull/199651","mergeCommit":{"message":"[SecuritySolution] Improve asset criticality bulk error when entities are duplicated (#199651)\n\n## Summary\r\n\r\n* Improve asset criticality bulk error when entities are duplicated\r\n* It also fixes the server errors line to be '1' based.\r\n\r\n\r\n\r\n### Performance\r\n\r\nTest parameters: file with +33k lines and ~1 MB size.\r\n* Before 6.24 seconds\r\n* After 6.46 seconds\r\n\r\nExecution time Increased ~0.22 seconds\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"02ac5fc90f08615d877befc05f9675838ade77b4"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199651","number":199651,"mergeCommit":{"message":"[SecuritySolution] Improve asset criticality bulk error when entities are duplicated (#199651)\n\n## Summary\r\n\r\n* Improve asset criticality bulk error when entities are duplicated\r\n* It also fixes the server errors line to be '1' based.\r\n\r\n\r\n\r\n### Performance\r\n\r\nTest parameters: file with +33k lines and ~1 MB size.\r\n* Before 6.24 seconds\r\n* After 6.46 seconds\r\n\r\nExecution time Increased ~0.22 seconds\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"02ac5fc90f08615d877befc05f9675838ade77b4"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Pablo Machado <[email protected]>
machadoum
added a commit
that referenced
this pull request
Nov 13, 2024
…ntities are duplicated (#199651) (#199971) # Backport This will backport the following commits from `main` to `8.16`: - [[SecuritySolution] Improve asset criticality bulk error when entities are duplicated (#199651)](#199651) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Pablo Machado","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T10:22:44Z","message":"[SecuritySolution] Improve asset criticality bulk error when entities are duplicated (#199651)\n\n## Summary\r\n\r\n* Improve asset criticality bulk error when entities are duplicated\r\n* It also fixes the server errors line to be '1' based.\r\n\r\n\r\n\r\n### Performance\r\n\r\nTest parameters: file with +33k lines and ~1 MB size.\r\n* Before 6.24 seconds\r\n* After 6.46 seconds\r\n\r\nExecution time Increased ~0.22 seconds\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"02ac5fc90f08615d877befc05f9675838ade77b4","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","Team: SecuritySolution","Theme: entity_analytics","Feature:Entity Analytics","Team:Entity Analytics","backport:version","v8.17.0","v8.16.1"],"number":199651,"url":"https://github.com/elastic/kibana/pull/199651","mergeCommit":{"message":"[SecuritySolution] Improve asset criticality bulk error when entities are duplicated (#199651)\n\n## Summary\r\n\r\n* Improve asset criticality bulk error when entities are duplicated\r\n* It also fixes the server errors line to be '1' based.\r\n\r\n\r\n\r\n### Performance\r\n\r\nTest parameters: file with +33k lines and ~1 MB size.\r\n* Before 6.24 seconds\r\n* After 6.46 seconds\r\n\r\nExecution time Increased ~0.22 seconds\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"02ac5fc90f08615d877befc05f9675838ade77b4"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199651","number":199651,"mergeCommit":{"message":"[SecuritySolution] Improve asset criticality bulk error when entities are duplicated (#199651)\n\n## Summary\r\n\r\n* Improve asset criticality bulk error when entities are duplicated\r\n* It also fixes the server errors line to be '1' based.\r\n\r\n\r\n\r\n### Performance\r\n\r\nTest parameters: file with +33k lines and ~1 MB size.\r\n* Before 6.24 seconds\r\n* After 6.46 seconds\r\n\r\nExecution time Increased ~0.22 seconds\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"02ac5fc90f08615d877befc05f9675838ade77b4"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/199968","number":199968,"state":"OPEN"},{"branch":"8.16","label":"v8.16.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
… are duplicated (elastic#199651) ## Summary * Improve asset criticality bulk error when entities are duplicated * It also fixes the server errors line to be '1' based.  ### Performance Test parameters: file with +33k lines and ~1 MB size. * Before 6.24 seconds * After 6.46 seconds Execution time Increased ~0.22 seconds ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
… are duplicated (elastic#199651) ## Summary * Improve asset criticality bulk error when entities are duplicated * It also fixes the server errors line to be '1' based.  ### Performance Test parameters: file with +33k lines and ~1 MB size. * Before 6.24 seconds * After 6.46 seconds Execution time Increased ~0.22 seconds ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Performance
Test parameters: file with +33k lines and ~1 MB size.
Execution time Increased ~0.22 seconds
Checklist
Delete any items that are not applicable to this PR.