fix: [Search:Playground page]Tooltip for Instructions is not accessible via keyboard #199607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le via keyboard Closes: elastic#199493
alexwizp
added
v9.0.0
release_note:skip
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
TattdCodeMonkey
approved these changes
Nov 12, 2024
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 12, 2024
…le via keyboard (elastic#199607) Closes: elastic#199493 ### Description Tooltip present for Instructions is not visible when reaching the field via keyboard. Tooltips which are visible for the user using mouse, should be also visible for the users using only keyboard. ### What was changed?: 1. `EuiIToolkip` was replaced to move a11y-friendly `EuiIconTip` ### Screen: https://github.com/user-attachments/assets/2d5fbc7b-0d80-4c0d-8e99-2ddd8aa9e1cf (cherry picked from commit 515dbe5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 12, 2024
…cessible via keyboard (#199607) (#199868) # Backport This will backport the following commits from `main` to `8.x`: - [fix: [Search:Playground page]Tooltip for Instructions is not accessible via keyboard (#199607)](#199607) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T19:27:59Z","message":"fix: [Search:Playground page]Tooltip for Instructions is not accessible via keyboard (#199607)\n\nCloses: #199493\r\n\r\n### Description\r\nTooltip present for Instructions is not visible when reaching the field\r\nvia keyboard. Tooltips which are visible for the user using mouse,\r\nshould be also visible for the users using only keyboard.\r\n\r\n### What was changed?: \r\n\r\n1. `EuiIToolkip` was replaced to move a11y-friendly `EuiIconTip`\r\n\r\n\r\n### Screen: \r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2d5fbc7b-0d80-4c0d-8e99-2ddd8aa9e1cf","sha":"515dbe5a2d646243dacb6b46b49964af3db6c754","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"fix: [Search:Playground page]Tooltip for Instructions is not accessible via keyboard","number":199607,"url":"https://github.com/elastic/kibana/pull/199607","mergeCommit":{"message":"fix: [Search:Playground page]Tooltip for Instructions is not accessible via keyboard (#199607)\n\nCloses: #199493\r\n\r\n### Description\r\nTooltip present for Instructions is not visible when reaching the field\r\nvia keyboard. Tooltips which are visible for the user using mouse,\r\nshould be also visible for the users using only keyboard.\r\n\r\n### What was changed?: \r\n\r\n1. `EuiIToolkip` was replaced to move a11y-friendly `EuiIconTip`\r\n\r\n\r\n### Screen: \r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2d5fbc7b-0d80-4c0d-8e99-2ddd8aa9e1cf","sha":"515dbe5a2d646243dacb6b46b49964af3db6c754"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199607","number":199607,"mergeCommit":{"message":"fix: [Search:Playground page]Tooltip for Instructions is not accessible via keyboard (#199607)\n\nCloses: #199493\r\n\r\n### Description\r\nTooltip present for Instructions is not visible when reaching the field\r\nvia keyboard. Tooltips which are visible for the user using mouse,\r\nshould be also visible for the users using only keyboard.\r\n\r\n### What was changed?: \r\n\r\n1. `EuiIToolkip` was replaced to move a11y-friendly `EuiIconTip`\r\n\r\n\r\n### Screen: \r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2d5fbc7b-0d80-4c0d-8e99-2ddd8aa9e1cf","sha":"515dbe5a2d646243dacb6b46b49964af3db6c754"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
…le via keyboard (elastic#199607) Closes: elastic#199493 ### Description Tooltip present for Instructions is not visible when reaching the field via keyboard. Tooltips which are visible for the user using mouse, should be also visible for the users using only keyboard. ### What was changed?: 1. `EuiIToolkip` was replaced to move a11y-friendly `EuiIconTip` ### Screen: https://github.com/user-attachments/assets/2d5fbc7b-0d80-4c0d-8e99-2ddd8aa9e1cf
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
…le via keyboard (elastic#199607) Closes: elastic#199493 ### Description Tooltip present for Instructions is not visible when reaching the field via keyboard. Tooltips which are visible for the user using mouse, should be also visible for the users using only keyboard. ### What was changed?: 1. `EuiIToolkip` was replaced to move a11y-friendly `EuiIconTip` ### Screen: https://github.com/user-attachments/assets/2d5fbc7b-0d80-4c0d-8e99-2ddd8aa9e1cf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #199493
Description
Tooltip present for Instructions is not visible when reaching the field via keyboard. Tooltips which are visible for the user using mouse, should be also visible for the users using only keyboard.
What was changed?:
EuiIToolkipwas replaced to move a11y-friendlyEuiIconTipScreen:
Screen.Recording.2024-11-11.at.12.26.13.mov