-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[time slider control] fix Time slider control needs to better sync with dashboard time range #199544
Conversation
Pinging @elastic/kibana-presentation (Team:Presentation) |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! code review and verified time slider updates with global date range.
Starting backport for target branches: 8.16, 8.x |
…th dashboard time range (elastic#199544) Closes elastic#199227 PR subscribes to reload$ and adjusts timeslider when parent reloads. --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 36be994)
…th dashboard time range (elastic#199544) Closes elastic#199227 PR subscribes to reload$ and adjusts timeslider when parent reloads. --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 36be994)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…sync with dashboard time range (#199544) (#199831) # Backport This will backport the following commits from `main` to `8.16`: - [[time slider control] fix Time slider control needs to better sync with dashboard time range (#199544)](#199544) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T17:01:41Z","message":"[time slider control] fix Time slider control needs to better sync with dashboard time range (#199544)\n\nCloses https://github.com/elastic/kibana/issues/199227\r\n\r\nPR subscribes to reload$ and adjusts timeslider when parent reloads.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"36be9947ce18f0601e8ad6d56b601475f6b7f2a5","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v9.0.0","backport:version","v8.17.0","v8.16.1"],"title":"[time slider control] fix Time slider control needs to better sync with dashboard time range","number":199544,"url":"https://github.com/elastic/kibana/pull/199544","mergeCommit":{"message":"[time slider control] fix Time slider control needs to better sync with dashboard time range (#199544)\n\nCloses https://github.com/elastic/kibana/issues/199227\r\n\r\nPR subscribes to reload$ and adjusts timeslider when parent reloads.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"36be9947ce18f0601e8ad6d56b601475f6b7f2a5"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199544","number":199544,"mergeCommit":{"message":"[time slider control] fix Time slider control needs to better sync with dashboard time range (#199544)\n\nCloses https://github.com/elastic/kibana/issues/199227\r\n\r\nPR subscribes to reload$ and adjusts timeslider when parent reloads.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"36be9947ce18f0601e8ad6d56b601475f6b7f2a5"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
…ync with dashboard time range (#199544) (#199832) # Backport This will backport the following commits from `main` to `8.x`: - [[time slider control] fix Time slider control needs to better sync with dashboard time range (#199544)](#199544) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T17:01:41Z","message":"[time slider control] fix Time slider control needs to better sync with dashboard time range (#199544)\n\nCloses https://github.com/elastic/kibana/issues/199227\r\n\r\nPR subscribes to reload$ and adjusts timeslider when parent reloads.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"36be9947ce18f0601e8ad6d56b601475f6b7f2a5","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v9.0.0","backport:version","v8.17.0","v8.16.1"],"title":"[time slider control] fix Time slider control needs to better sync with dashboard time range","number":199544,"url":"https://github.com/elastic/kibana/pull/199544","mergeCommit":{"message":"[time slider control] fix Time slider control needs to better sync with dashboard time range (#199544)\n\nCloses https://github.com/elastic/kibana/issues/199227\r\n\r\nPR subscribes to reload$ and adjusts timeslider when parent reloads.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"36be9947ce18f0601e8ad6d56b601475f6b7f2a5"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199544","number":199544,"mergeCommit":{"message":"[time slider control] fix Time slider control needs to better sync with dashboard time range (#199544)\n\nCloses https://github.com/elastic/kibana/issues/199227\r\n\r\nPR subscribes to reload$ and adjusts timeslider when parent reloads.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"36be9947ce18f0601e8ad6d56b601475f6b7f2a5"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
…th dashboard time range (elastic#199544) Closes elastic#199227 PR subscribes to reload$ and adjusts timeslider when parent reloads. --------- Co-authored-by: Elastic Machine <[email protected]>
…th dashboard time range (elastic#199544) Closes elastic#199227 PR subscribes to reload$ and adjusts timeslider when parent reloads. --------- Co-authored-by: Elastic Machine <[email protected]>
…th dashboard time range (elastic#199544) Closes elastic#199227 PR subscribes to reload$ and adjusts timeslider when parent reloads. --------- Co-authored-by: Elastic Machine <[email protected]>
Closes #199227
PR subscribes to reload$ and adjusts timeslider when parent reloads.