Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[time slider control] fix Time slider control needs to better sync with dashboard time range #199544

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Nov 8, 2024

Closes #199227

PR subscribes to reload$ and adjusts timeslider when parent reloads.

@nreese nreese marked this pull request as ready for review November 8, 2024 20:14
@nreese nreese requested a review from a team as a code owner November 8, 2024 20:14
@nreese nreese added release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v9.0.0 v8.17.0 labels Nov 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese added the backport:version Backport to applied version labels label Nov 8, 2024
@nreese
Copy link
Contributor Author

nreese commented Nov 11, 2024

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
controls 459.8KB 460.0KB +167.0B

History

@nickpeihl nickpeihl self-requested a review November 12, 2024 14:03
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! code review and verified time slider updates with global date range.

@nreese nreese merged commit 36be994 into elastic:main Nov 12, 2024
28 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11802083605

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 12, 2024
…th dashboard time range (elastic#199544)

Closes elastic#199227

PR subscribes to reload$ and adjusts timeslider when parent reloads.

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 36be994)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 12, 2024
…th dashboard time range (elastic#199544)

Closes elastic#199227

PR subscribes to reload$ and adjusts timeslider when parent reloads.

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 36be994)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 12, 2024
…sync with dashboard time range (#199544) (#199831)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[time slider control] fix Time slider control needs to better sync
with dashboard time range
(#199544)](#199544)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T17:01:41Z","message":"[time
slider control] fix Time slider control needs to better sync with
dashboard time range (#199544)\n\nCloses
https://github.com/elastic/kibana/issues/199227\r\n\r\nPR subscribes to
reload$ and adjusts timeslider when parent
reloads.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"36be9947ce18f0601e8ad6d56b601475f6b7f2a5","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v9.0.0","backport:version","v8.17.0","v8.16.1"],"title":"[time
slider control] fix Time slider control needs to better sync with
dashboard time
range","number":199544,"url":"https://github.com/elastic/kibana/pull/199544","mergeCommit":{"message":"[time
slider control] fix Time slider control needs to better sync with
dashboard time range (#199544)\n\nCloses
https://github.com/elastic/kibana/issues/199227\r\n\r\nPR subscribes to
reload$ and adjusts timeslider when parent
reloads.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"36be9947ce18f0601e8ad6d56b601475f6b7f2a5"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199544","number":199544,"mergeCommit":{"message":"[time
slider control] fix Time slider control needs to better sync with
dashboard time range (#199544)\n\nCloses
https://github.com/elastic/kibana/issues/199227\r\n\r\nPR subscribes to
reload$ and adjusts timeslider when parent
reloads.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"36be9947ce18f0601e8ad6d56b601475f6b7f2a5"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 12, 2024
…ync with dashboard time range (#199544) (#199832)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[time slider control] fix Time slider control needs to better sync
with dashboard time range
(#199544)](#199544)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T17:01:41Z","message":"[time
slider control] fix Time slider control needs to better sync with
dashboard time range (#199544)\n\nCloses
https://github.com/elastic/kibana/issues/199227\r\n\r\nPR subscribes to
reload$ and adjusts timeslider when parent
reloads.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"36be9947ce18f0601e8ad6d56b601475f6b7f2a5","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v9.0.0","backport:version","v8.17.0","v8.16.1"],"title":"[time
slider control] fix Time slider control needs to better sync with
dashboard time
range","number":199544,"url":"https://github.com/elastic/kibana/pull/199544","mergeCommit":{"message":"[time
slider control] fix Time slider control needs to better sync with
dashboard time range (#199544)\n\nCloses
https://github.com/elastic/kibana/issues/199227\r\n\r\nPR subscribes to
reload$ and adjusts timeslider when parent
reloads.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"36be9947ce18f0601e8ad6d56b601475f6b7f2a5"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199544","number":199544,"mergeCommit":{"message":"[time
slider control] fix Time slider control needs to better sync with
dashboard time range (#199544)\n\nCloses
https://github.com/elastic/kibana/issues/199227\r\n\r\nPR subscribes to
reload$ and adjusts timeslider when parent
reloads.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"36be9947ce18f0601e8ad6d56b601475f6b7f2a5"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <[email protected]>
tkajtoch pushed a commit to tkajtoch/kibana that referenced this pull request Nov 12, 2024
…th dashboard time range (elastic#199544)

Closes elastic#199227

PR subscribes to reload$ and adjusts timeslider when parent reloads.

---------

Co-authored-by: Elastic Machine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
…th dashboard time range (elastic#199544)

Closes elastic#199227

PR subscribes to reload$ and adjusts timeslider when parent reloads.

---------

Co-authored-by: Elastic Machine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
…th dashboard time range (elastic#199544)

Closes elastic#199227

PR subscribes to reload$ and adjusts timeslider when parent reloads.

---------

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.16.0 v8.16.1 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time slider control needs to better sync with dashboard time range
4 participants