fix(slo): remove extra field from synthetics indicator params #199542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdelemme
added
backport:prev-major
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
mgiota
approved these changes
Nov 8, 2024
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.15, 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 12, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 12, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 12, 2024
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 12, 2024
…199542) (#199851) # Backport This will backport the following commits from `main` to `8.15`: - [fix(slo): remove extra field from synthetics indicator params (#199542)](#199542) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T18:15:02Z","message":"fix(slo): remove extra field from synthetics indicator params (#199542)","sha":"eea4a204e40869a584f485ed52ed350f65cb57c9","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management","v8.17.0"],"title":"fix(slo): remove extra field from synthetics indicator params","number":199542,"url":"https://github.com/elastic/kibana/pull/199542","mergeCommit":{"message":"fix(slo): remove extra field from synthetics indicator params (#199542)","sha":"eea4a204e40869a584f485ed52ed350f65cb57c9"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199542","number":199542,"mergeCommit":{"message":"fix(slo): remove extra field from synthetics indicator params (#199542)","sha":"eea4a204e40869a584f485ed52ed350f65cb57c9"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kevin Delemme <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 12, 2024
…199542) (#199852) # Backport This will backport the following commits from `main` to `8.16`: - [fix(slo): remove extra field from synthetics indicator params (#199542)](#199542) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T18:15:02Z","message":"fix(slo): remove extra field from synthetics indicator params (#199542)","sha":"eea4a204e40869a584f485ed52ed350f65cb57c9","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management","v8.17.0"],"title":"fix(slo): remove extra field from synthetics indicator params","number":199542,"url":"https://github.com/elastic/kibana/pull/199542","mergeCommit":{"message":"fix(slo): remove extra field from synthetics indicator params (#199542)","sha":"eea4a204e40869a584f485ed52ed350f65cb57c9"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199542","number":199542,"mergeCommit":{"message":"fix(slo): remove extra field from synthetics indicator params (#199542)","sha":"eea4a204e40869a584f485ed52ed350f65cb57c9"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kevin Delemme <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 12, 2024
…199542) (#199853) # Backport This will backport the following commits from `main` to `8.x`: - [fix(slo): remove extra field from synthetics indicator params (#199542)](#199542) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T18:15:02Z","message":"fix(slo): remove extra field from synthetics indicator params (#199542)","sha":"eea4a204e40869a584f485ed52ed350f65cb57c9","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management","v8.17.0"],"title":"fix(slo): remove extra field from synthetics indicator params","number":199542,"url":"https://github.com/elastic/kibana/pull/199542","mergeCommit":{"message":"fix(slo): remove extra field from synthetics indicator params (#199542)","sha":"eea4a204e40869a584f485ed52ed350f65cb57c9"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199542","number":199542,"mergeCommit":{"message":"fix(slo): remove extra field from synthetics indicator params (#199542)","sha":"eea4a204e40869a584f485ed52ed350f65cb57c9"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kevin Delemme <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #199501
🐛 Summary
This PR removes the unused
data-test-subjprops from the selected options, which was causing issue when creating an SLO because this prop was sent along the value and label props.📣 Release note
Fix the Synthetics SLI when using tags, monitors or projects specific values