Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenAPI] Fix fleet filepath API parameter #199538

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 8, 2024

Summary

Relates to #199360

While testing more linters, the following error was identified:

redocly lint output/kibana.yaml --config linters/redocly.yaml --max-problems 500 --format stylish
validating output/kibana.yaml...
output/kibana.yaml:
23896:17 error path-parameters-defined Path parameter filePath is not used in the path /api/fleet/epm/packages/{pkgName}/{pkgVersion}/{filePath*}.

This was because there was a mismatch between what was declared in the path "filepath*" and what was declared in the parameter definition "filePath".

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team docs v8.16.0 backport:version Backport to applied version labels v8.17.0 labels Nov 8, 2024
@lcawl lcawl requested a review from a team as a code owner November 8, 2024 18:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@lcawl lcawl marked this pull request as draft November 13, 2024 17:49
@lcawl lcawl marked this pull request as ready for review November 13, 2024 18:47
@lcawl lcawl requested a review from a team as a code owner November 13, 2024 18:47
@jloleysens
Copy link
Contributor

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

expected head sha didn’t match current head ref.

@lcawl lcawl enabled auto-merge (squash) November 14, 2024 20:22
@lcawl lcawl merged commit ba6ffec into elastic:main Nov 14, 2024
21 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11846313936

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@lcawl lcawl deleted the fleet-api-fixes branch November 14, 2024 22:06
@lcawl lcawl added v8.16.1 and removed v8.16.0 labels Nov 14, 2024
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.16 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.16:
- [OpenAPI][DOCS] Add descriptions for alerting rule flapping properties (#200112)
- [OAS] Publish OAS bundles to bump.sh (#197482)
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [ResponseOps] [Cases] Attach file to case API (#198377)
- [OAS] Publish OAS bundles to bump.sh (#197482)
- Changes deprecated SO HTTP APIs deprecation field to object (#197936)
- OpenAPI docs for APM UI APIs (#197946)
- [Core] [UA] Support API Deprecations (#196081)

Manual backport

To create the backport manually run:

node scripts/backport --pr 199538

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit to lcawl/kibana that referenced this pull request Nov 14, 2024
lcawl added a commit to lcawl/kibana that referenced this pull request Nov 14, 2024
@lcawl
Copy link
Contributor Author

lcawl commented Nov 14, 2024

💚 All backports created successfully

Status Branch Result
8.x
8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Nov 15, 2024
# Backport

This will backport the following commits from `main` to `8.16`:
- [[OpenAPI] Fix fleet filepath API parameter
(#199538)](#199538)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-14T22:05:39Z","message":"[OpenAPI]
Fix fleet filepath API parameter
(#199538)","sha":"ba6ffec9e769669bce8a265cfb55fc142471fbe0","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","docs","backport:version","v8.17.0","v8.16.1"],"number":199538,"url":"https://github.com/elastic/kibana/pull/199538","mergeCommit":{"message":"[OpenAPI]
Fix fleet filepath API parameter
(#199538)","sha":"ba6ffec9e769669bce8a265cfb55fc142471fbe0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199538","number":199538,"mergeCommit":{"message":"[OpenAPI]
Fix fleet filepath API parameter
(#199538)","sha":"ba6ffec9e769669bce8a265cfb55fc142471fbe0"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
lcawl added a commit that referenced this pull request Nov 15, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[OpenAPI] Fix fleet filepath API parameter
(#199538)](#199538)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-14T22:05:39Z","message":"[OpenAPI]
Fix fleet filepath API parameter
(#199538)","sha":"ba6ffec9e769669bce8a265cfb55fc142471fbe0","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","docs","backport:version","v8.17.0","v8.16.1"],"number":199538,"url":"https://github.com/elastic/kibana/pull/199538","mergeCommit":{"message":"[OpenAPI]
Fix fleet filepath API parameter
(#199538)","sha":"ba6ffec9e769669bce8a265cfb55fc142471fbe0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199538","number":199538,"mergeCommit":{"message":"[OpenAPI]
Fix fleet filepath API parameter
(#199538)","sha":"ba6ffec9e769669bce8a265cfb55fc142471fbe0"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels docs release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.16.1 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants