Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Unskip get_render_app_wrapper test #199456

Merged
merged 8 commits into from
Nov 20, 2024
Merged

[Discover] Unskip get_render_app_wrapper test #199456

merged 8 commits into from
Nov 20, 2024

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Nov 8, 2024 •
edited by kibanamachine
Loading

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 8, 2024
@jughosta jughosta self-assigned this Nov 8, 2024
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7355

[✅] test/functional/apps/discover/context_awareness/config.ts: 25/25 tests passed.
[❌] x-pack/test_serverless/functional/test_suites/security/config.context_awareness.ts: 18/25 tests passed.

see run history

@jughosta
Copy link
Contributor Author

jughosta commented Nov 8, 2024

Hi @davismcphee,

Seems like log.level column is not added sometimes. What could be the issue there?

discovercontextawareness extension getRenderAppWrapper data view mode should all-1a1931adfebc28b6f231ce3f2d71ecf3b47fcf6168903ded4414d5b2ac2af15e

@davismcphee
Copy link
Contributor

Seems like log.level column is not added sometimes. What could be the issue there?

It looks to be unrelated to this test, and caused by a bug in the getDefaultAppState implementation. I've been unable to reproduce it so far when debugging, but I need to figure it out soon because it's causing issues in some of our other tests too.

This is a workaround, but since it's unrelated, how about we just update this test to not care about the number of columns? Maybe we could use data-gridcell-column-id to target the cell instead of data-gridcell-column-index. That way we could get this unskipped while we continue to look into the getDefaultAppState bug.

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7417

[❌] test/functional/apps/discover/context_awareness/config.ts: 24/30 tests passed.
[❌] x-pack/test_serverless/functional/test_suites/security/config.context_awareness.ts: 10/30 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7426

[✅] test/functional/apps/discover/context_awareness/config.ts: 25/25 tests passed.

see run history

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

cc @jughosta

davismcphee
davismcphee approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that did it and the flakiness is gone (hopefully) 🎉 Thanks for addressing it! I'm not sure if approving while in a draft state will actually work, but I'm gonna do it anyway... I'll re-review if needed once published 🙂

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7428

[✅] x-pack/test_serverless/functional/test_suites/security/config.context_awareness.ts: 50/50 tests passed.

see run history

@jughosta jughosta marked this pull request as ready for review November 20, 2024 08:50
@jughosta jughosta requested review from a team as code owners November 20, 2024 08:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@jughosta jughosta enabled auto-merge (squash) November 20, 2024 08:50
pheyos
pheyos approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test/functional/services/data_grid.ts changes LGTM

@jughosta jughosta merged commit b512ee4 into elastic:main Nov 20, 2024
23 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11930330104

@jughosta jughosta deleted the 199356-unskip-context-test branch November 20, 2024 09:21
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 20, 2024
@jughosta
[Discover] Unskip get_render_app_wrapper test (elastic#199456)
64d5e19 
- Closes elastic#199356

(cherry picked from commit b512ee4)
@kibanamachine kibanamachine mentioned this pull request Nov 20, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 20, 2024
@kibanamachine @jughosta
[8.x] [Discover] Unskip get_render_app_wrapper test (#199456) (#200868)
7126046 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Discover] Unskip get_render_app_wrapper test
(#199456)](#199456)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-20T09:19:24Z","message":"[Discover]
Unskip get_render_app_wrapper test (#199456)\n\n- Closes
https://github.com/elastic/kibana/issues/199356","sha":"b512ee4803f4383f4592dc1cc015f5c550866130","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor"],"title":"[Discover]
Unskip get_render_app_wrapper
test","number":199456,"url":"https://github.com/elastic/kibana/pull/199456","mergeCommit":{"message":"[Discover]
Unskip get_render_app_wrapper test (#199456)\n\n- Closes
https://github.com/elastic/kibana/issues/199356","sha":"b512ee4803f4383f4592dc1cc015f5c550866130"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199456","number":199456,"mergeCommit":{"message":"[Discover]
Unskip get_render_app_wrapper test (#199456)\n\n- Closes
https://github.com/elastic/kibana/issues/199356","sha":"b512ee4803f4383f4592dc1cc015f5c550866130"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <[email protected]>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
@jughosta @paulinashakirova
[Discover] Unskip get_render_app_wrapper test (elastic#199456)
032f2d9 
- Closes elastic#199356
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@jughosta @CAWilson94
[Discover] Unskip get_render_app_wrapper test (elastic#199456)
e719f6d 
- Closes elastic#199356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

@pheyos pheyos pheyos approved these changes

Assignees

@jughosta jughosta

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
5 participants
@jughosta @kibanamachine @davismcphee @elasticmachine @pheyos