Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Anomaly Detection: Migrate chart tooltip from SCSS to emotion #199417

Merged
merged 2 commits into from
Nov 11, 2024
Merged

[ML] Anomaly Detection: Migrate chart tooltip from SCSS to emotion #199417

merged 2 commits into from
Nov 11, 2024

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Nov 8, 2024 •
edited by kibanamachine
Loading

Summary

Part of #140695

Migrates SCSS to emotion for the Anomaly Detection chart tooltip.

CleanShot 2024-11-08 at 08 01 22@2x

Checklist

@walterra walterra added :ml Feature:Anomaly Detection ML anomaly detection release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:version Backport to applied version labels v8.17.0 labels Nov 8, 2024
@walterra walterra self-assigned this Nov 8, 2024
@walterra walterra requested review from a team as code owners November 8, 2024 07:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested (light and dark mode) and LGTM

jgowdyelastic
jgowdyelastic approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 2013 2143 +130

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.5MB 4.7MB +178.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ml 75.4KB 75.4KB +49.0B

History

cc @walterra

@walterra walterra merged commit 10db645 into elastic:main Nov 11, 2024
23 checks passed
@walterra walterra deleted the ml-remove-scss-chart-tooltip branch November 11, 2024 18:12
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11783934507

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 11, 2024
@walterra
[ML] Anomaly Detection: Migrate chart tooltip from SCSS to emotion (e…
a161432 
…lastic#199417)

## Summary

Part of elastic#140695

Migrates SCSS to emotion for the Anomaly Detection chart tooltip.

![CleanShot 2024-11-08 at 08 01
22@2x](https://github.com/user-attachments/assets/a7cd94c2-15b7-42bc-b98a-3596eaeeafe1)

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)

(cherry picked from commit 10db645)
@kibanamachine kibanamachine mentioned this pull request Nov 11, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 11, 2024
@kibanamachine @walterra
[8.x] [ML] Anomaly Detection: Migrate chart tooltip from SCSS to emot…
e88bacb 
…ion (#199417) (#199684)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Anomaly Detection: Migrate chart tooltip from SCSS to emotion
(#199417)](#199417)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Walter
Rafelsberger","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-11T18:12:27Z","message":"[ML]
Anomaly Detection: Migrate chart tooltip from SCSS to emotion
(#199417)\n\n## Summary\r\n\r\nPart of
https://github.com/elastic/kibana/issues/140695\r\n\r\nMigrates SCSS to
emotion for the Anomaly Detection chart tooltip.\r\n\r\n![CleanShot
2024-11-08 at 08
01\r\n22@2x](https://github.com/user-attachments/assets/a7cd94c2-15b7-42bc-b98a-3596eaeeafe1)\r\n\r\n###
Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] This was checked for breaking
API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"10db64579ce7d3ac8d75724c2fbef11f10e2201e","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","Feature:Anomaly
Detection","release_note:skip","v9.0.0","backport:version","v8.17.0"],"title":"[ML]
Anomaly Detection: Migrate chart tooltip from SCSS to
emotion","number":199417,"url":"https://github.com/elastic/kibana/pull/199417","mergeCommit":{"message":"[ML]
Anomaly Detection: Migrate chart tooltip from SCSS to emotion
(#199417)\n\n## Summary\r\n\r\nPart of
https://github.com/elastic/kibana/issues/140695\r\n\r\nMigrates SCSS to
emotion for the Anomaly Detection chart tooltip.\r\n\r\n![CleanShot
2024-11-08 at 08
01\r\n22@2x](https://github.com/user-attachments/assets/a7cd94c2-15b7-42bc-b98a-3596eaeeafe1)\r\n\r\n###
Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] This was checked for breaking
API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"10db64579ce7d3ac8d75724c2fbef11f10e2201e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199417","number":199417,"mergeCommit":{"message":"[ML]
Anomaly Detection: Migrate chart tooltip from SCSS to emotion
(#199417)\n\n## Summary\r\n\r\nPart of
https://github.com/elastic/kibana/issues/140695\r\n\r\nMigrates SCSS to
emotion for the Anomaly Detection chart tooltip.\r\n\r\n![CleanShot
2024-11-08 at 08
01\r\n22@2x](https://github.com/user-attachments/assets/a7cd94c2-15b7-42bc-b98a-3596eaeeafe1)\r\n\r\n###
Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] This was checked for breaking
API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"10db64579ce7d3ac8d75724c2fbef11f10e2201e"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Walter Rafelsberger <[email protected]>
tkajtoch pushed a commit to tkajtoch/kibana that referenced this pull request Nov 12, 2024
@walterra @tkajtoch
[ML] Anomaly Detection: Migrate chart tooltip from SCSS to emotion (e…
c7170de 
…lastic#199417)

## Summary

Part of elastic#140695

Migrates SCSS to emotion for the Anomaly Detection chart tooltip.

![CleanShot 2024-11-08 at 08 01
22@2x](https://github.com/user-attachments/assets/a7cd94c2-15b7-42bc-b98a-3596eaeeafe1)

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
@walterra walterra mentioned this pull request Nov 13, 2024
Open
65 tasks
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
@walterra @CAWilson94
[ML] Anomaly Detection: Migrate chart tooltip from SCSS to emotion (e…
27ffa14 
…lastic#199417)

## Summary

Part of elastic#140695

Migrates SCSS to emotion for the Anomaly Detection chart tooltip.

![CleanShot 2024-11-08 at 08 01
22@2x](https://github.com/user-attachments/assets/a7cd94c2-15b7-42bc-b98a-3596eaeeafe1)

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@peteharverson peteharverson peteharverson approved these changes

@ryankeairns ryankeairns ryankeairns approved these changes

Assignees

@walterra walterra

Labels
backport:version Backport to applied version labels Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@walterra @elasticmachine @kibanamachine @ryankeairns @peteharverson @jgowdyelastic