Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA]Change screenshot size for metricbeat dashboard test #199378

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

marius-dr
Copy link
Member

@marius-dr marius-dr commented Nov 7, 2024

Summary

Change the default screenshot compare size for the metricbeat dashboard.

@marius-dr marius-dr added test release_note:skip Skip the PR/issue when compiling release notes test-stack-integration v9.0.0 backport:version Backport to applied version labels v8.17.0 v8.16.1 labels Nov 7, 2024
@bhavyarm bhavyarm self-requested a review November 7, 2024 21:00
Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marius-dr marius-dr enabled auto-merge (squash) November 7, 2024 21:29
@marius-dr marius-dr merged commit c5df736 into main Nov 7, 2024
21 checks passed
@marius-dr marius-dr deleted the marius-dr-patch-1 branch November 7, 2024 23:22
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11733024006

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 7, 2024
)

## Summary

Change the default screenshot compare size for the metricbeat dashboard.

(cherry picked from commit c5df736)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 7, 2024
)

## Summary

Change the default screenshot compare size for the metricbeat dashboard.

(cherry picked from commit c5df736)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 8, 2024
…) (#199398)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[QA]Change screenshot size for metricbeat dashboard test
(#199378)](#199378)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marius
Dragomir","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-07T23:22:34Z","message":"[QA]Change
screenshot size for metricbeat dashboard test (#199378)\n\n##
Summary\r\n\r\nChange the default screenshot compare size for the
metricbeat
dashboard.","sha":"c5df73661dccf44df52ff8bad4b7d4e657c37332","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","test-stack-integration","v9.0.0","backport:version","v8.17.0","v8.16.1"],"title":"[QA]Change
screenshot size for metricbeat dashboard
test","number":199378,"url":"https://github.com/elastic/kibana/pull/199378","mergeCommit":{"message":"[QA]Change
screenshot size for metricbeat dashboard test (#199378)\n\n##
Summary\r\n\r\nChange the default screenshot compare size for the
metricbeat
dashboard.","sha":"c5df73661dccf44df52ff8bad4b7d4e657c37332"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199378","number":199378,"mergeCommit":{"message":"[QA]Change
screenshot size for metricbeat dashboard test (#199378)\n\n##
Summary\r\n\r\nChange the default screenshot compare size for the
metricbeat
dashboard.","sha":"c5df73661dccf44df52ff8bad4b7d4e657c37332"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Marius Dragomir <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 8, 2024
) (#199397)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[QA]Change screenshot size for metricbeat dashboard test
(#199378)](#199378)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marius
Dragomir","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-07T23:22:34Z","message":"[QA]Change
screenshot size for metricbeat dashboard test (#199378)\n\n##
Summary\r\n\r\nChange the default screenshot compare size for the
metricbeat
dashboard.","sha":"c5df73661dccf44df52ff8bad4b7d4e657c37332","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","test-stack-integration","v9.0.0","backport:version","v8.17.0","v8.16.1"],"title":"[QA]Change
screenshot size for metricbeat dashboard
test","number":199378,"url":"https://github.com/elastic/kibana/pull/199378","mergeCommit":{"message":"[QA]Change
screenshot size for metricbeat dashboard test (#199378)\n\n##
Summary\r\n\r\nChange the default screenshot compare size for the
metricbeat
dashboard.","sha":"c5df73661dccf44df52ff8bad4b7d4e657c37332"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199378","number":199378,"mergeCommit":{"message":"[QA]Change
screenshot size for metricbeat dashboard test (#199378)\n\n##
Summary\r\n\r\nChange the default screenshot compare size for the
metricbeat
dashboard.","sha":"c5df73661dccf44df52ff8bad4b7d4e657c37332"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Marius Dragomir <[email protected]>
mbondyra pushed a commit to mbondyra/kibana that referenced this pull request Nov 8, 2024
)

## Summary

Change the default screenshot compare size for the metricbeat dashboard.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 8, 2024
)

## Summary

Change the default screenshot compare size for the metricbeat dashboard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes test test-stack-integration v8.16.0 v8.16.1 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants