Fix ess deployment agnostic tests #199341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fake-haris
added
test_xpack_functional
release_note:skip
dmlemeshko
reviewed
Nov 7, 2024
.../test/api_integration/deployment_agnostic/apis/observability/dataset_quality/integrations.ts
Outdated
Show resolved
Hide resolved
dmlemeshko
reviewed
Nov 7, 2024
.../test/api_integration/deployment_agnostic/apis/observability/dataset_quality/integrations.ts
Outdated
Show resolved
Hide resolved
.../test/api_integration/deployment_agnostic/apis/observability/dataset_quality/integrations.ts
Outdated
Show resolved
Hide resolved
.../test/api_integration/deployment_agnostic/apis/observability/dataset_quality/integrations.ts
Outdated
Show resolved
Hide resolved
dmlemeshko
reviewed
Nov 8, 2024
.../test/api_integration/deployment_agnostic/apis/observability/dataset_quality/integrations.ts
Outdated
Show resolved
Hide resolved
dmlemeshko
reviewed
Nov 8, 2024
.../test/api_integration/deployment_agnostic/apis/observability/dataset_quality/integrations.ts
Outdated
Show resolved
Hide resolved
wayneseymour
approved these changes
Nov 8, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @fake-haris |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed assertions in integrations.ts. #198894
Details
For installed and custom integrations: We fetch integrations in before step and concat them with the additional expected integrations.
For integrations datasets map: We fetch the proper entry from the integrations list.