Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Canvas can not render Map with query or filter in 8.15 #199339

Merged
merged 2 commits into from
Nov 8, 2024
Merged

fix Canvas can not render Map with query or filter in 8.15 #199339

merged 2 commits into from
Nov 8, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Nov 7, 2024 •
edited
Loading

Resolves #199318. Issue only exists in 8.15 branch.

Test steps

  1. install sample web logs
  2. create new canvas work pad
  3. Click "Add from library" and add "[Logs] Total Requests and Bytes" map to workpad
  4. Click panel actions button and select "Edit map"
  5. Add query "bytes > 5000" to map and click "Save and return".
  6. Ensure map panel is rendered with filter notification popover
    Image

@nreese nreese added project:embeddableRebuild backport:version Backport to applied version labels v8.15.4 labels Nov 7, 2024
@nreese nreese marked this pull request as ready for review November 7, 2024 15:22
@nreese nreese added release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Nov 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese
Copy link
Contributor Author

nreese commented Nov 7, 2024

@elasticmachine merge upstream

@nreese nreese added loe:small Small Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. v8.15.5 and removed v8.15.4 labels Nov 7, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 529.7KB 529.8KB +64.0B

@nickpeihl nickpeihl self-requested a review November 8, 2024 18:59
nickpeihl
nickpeihl approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! tested and code review

@nreese nreese merged commit 111b23c into elastic:8.15 Nov 8, 2024
27 checks passed
@nreese nreese mentioned this pull request Nov 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels Feature:Canvas impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort project:embeddableRebuild release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.15.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nreese @elasticmachine @nickpeihl