Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] SLO Availability sync delay field to use timestamp instead of event.ingested !! #199308

Merged
merged 5 commits into from
Nov 20, 2024
Merged

[Synthetics] SLO Availability sync delay field to use timestamp instead of event.ingested !! #199308

merged 5 commits into from
Nov 20, 2024

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Nov 7, 2024 •
edited by kibanamachine
Loading

Summary

Fixes #196548

SLO Availability sync delay field to use @timestamp instead of event.ingested !!

Testing

  • Make sure Synthetics availability SLOs works as expected in serverless and stateful
  • Make sure when SLO is updated, it continues to work

@shahzad31 shahzad31 requested a review from a team as a code owner November 7, 2024 12:51
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Nov 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 added backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development release_note:skip Skip the PR/issue when compiling release notes labels Nov 7, 2024
@shahzad31 shahzad31 marked this pull request as draft November 7, 2024 15:04
@shahzad31 shahzad31 marked this pull request as ready for review November 20, 2024 12:40
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 20, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 09674cf
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-199308-09674cfc8e4c

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #4 / #getDataUsageMetricsFiltersFromUrlParams should use given relative startDate and endDate values URL params
  • [job] [logs] Jest Tests #2 / multiLineStringDiffAlgorithm if all three versions are different - scenario ABC does not exceed performance limits when diffing and merging extra large input texts

Metrics [docs]

✅ unchanged

History

@kdelemme kdelemme mentioned this pull request Nov 20, 2024
Closed
@shahzad31 shahzad31 merged commit c9540d9 into elastic:main Nov 20, 2024
26 checks passed
@shahzad31 shahzad31 deleted the fix-timestamp-field-slo branch November 20, 2024 15:36
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11936663854

@shahzad31 shahzad31 added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development labels Nov 20, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11936691492

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 20, 2024
@shahzad31
[Synthetics] SLO Availability sync delay field to use timestamp inste…
5a98a42 
…ad of event.ingested !! (elastic#199308)

## Summary

Fixes elastic#196548

SLO Availability sync delay field to use `@timestamp` instead of
`event.ingested` !!

### Testing

- Make sure Synthetics availability SLOs works as expected in serverless
and stateful
- Make sure when SLO is updated, it continues to work

(cherry picked from commit c9540d9)
@kibanamachine kibanamachine mentioned this pull request Nov 20, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 20, 2024
@kibanamachine @shahzad31
[8.x] [Synthetics] SLO Availability sync delay field to use timestamp…
0318a59 
… instead of event.ingested !! (#199308) (#200970)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Synthetics] SLO Availability sync delay field to use timestamp
instead of event.ingested !!
(#199308)](#199308)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-20T15:36:33Z","message":"[Synthetics]
SLO Availability sync delay field to use timestamp instead of
event.ingested !! (#199308)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/196548\r\n\r\nSLO Availability
sync delay field to use `@timestamp` instead of\r\n`event.ingested`
!!\r\n\r\n\r\n### Testing\r\n\r\n- Make sure Synthetics availability
SLOs works as expected in serverless\r\nand stateful\r\n- Make sure when
SLO is updated, it continues to
work","sha":"c9540d9d545c1974927d57f195b77f0c180a78c3","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics]
SLO Availability sync delay field to use timestamp instead of
event.ingested
!!","number":199308,"url":"https://github.com/elastic/kibana/pull/199308","mergeCommit":{"message":"[Synthetics]
SLO Availability sync delay field to use timestamp instead of
event.ingested !! (#199308)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/196548\r\n\r\nSLO Availability
sync delay field to use `@timestamp` instead of\r\n`event.ingested`
!!\r\n\r\n\r\n### Testing\r\n\r\n- Make sure Synthetics availability
SLOs works as expected in serverless\r\nand stateful\r\n- Make sure when
SLO is updated, it continues to
work","sha":"c9540d9d545c1974927d57f195b77f0c180a78c3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199308","number":199308,"mergeCommit":{"message":"[Synthetics]
SLO Availability sync delay field to use timestamp instead of
event.ingested !! (#199308)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/196548\r\n\r\nSLO Availability
sync delay field to use `@timestamp` instead of\r\n`event.ingested`
!!\r\n\r\n\r\n### Testing\r\n\r\n- Make sure Synthetics availability
SLOs works as expected in serverless\r\nand stateful\r\n- Make sure when
SLO is updated, it continues to
work","sha":"c9540d9d545c1974927d57f195b77f0c180a78c3"}}]}] BACKPORT-->

Co-authored-by: Shahzad <[email protected]>
TattdCodeMonkey pushed a commit to TattdCodeMonkey/kibana that referenced this pull request Nov 21, 2024
@shahzad31 @TattdCodeMonkey
[Synthetics] SLO Availability sync delay field to use timestamp inste…
283f9ec 
…ad of event.ingested !! (elastic#199308)

## Summary

Fixes elastic#196548

SLO Availability sync delay field to use `@timestamp` instead of
`event.ingested` !!


### Testing

- Make sure Synthetics availability SLOs works as expected in serverless
and stateful
- Make sure when SLO is updated, it continues to work
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
@shahzad31 @paulinashakirova
[Synthetics] SLO Availability sync delay field to use timestamp inste…
16242ca 
…ad of event.ingested !! (elastic#199308)

## Summary

Fixes elastic#196548

SLO Availability sync delay field to use `@timestamp` instead of
`event.ingested` !!


### Testing

- Make sure Synthetics availability SLOs works as expected in serverless
and stateful
- Make sure when SLO is updated, it continues to work
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@shahzad31 @CAWilson94
[Synthetics] SLO Availability sync delay field to use timestamp inste…
b8de361 
…ad of event.ingested !! (elastic#199308)

## Summary

Fixes elastic#196548

SLO Availability sync delay field to use `@timestamp` instead of
`event.ingested` !!


### Testing

- Make sure Synthetics availability SLOs works as expected in serverless
and stateful
- Make sure when SLO is updated, it continues to work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdelemme kdelemme kdelemme approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SLOs] Synthetics availability SLI is broken on serverless
4 participants
@shahzad31 @elasticmachine @kibanamachine @kdelemme