Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Security Solution] Deletes Old Timeline Code (#196243) #199287

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Summary

Fixes elastic/security-team#9676

This is follow up of the PR :
elastic#195959 where we had removed
feature flag `unifiedComponentsInTimelineDisabled`.

This PR completes unified components migration in Timeline.

## Changes

Most changes in this PR are :

1. Deletion for the obsolete code.
2. Refactoring of needed utils ( only 3. have marked in comments below )
3. Updating import path of above utils.

(cherry picked from commit c9d167f)
@kibanamachine kibanamachine merged commit f81ee32 into elastic:8.x Nov 7, 2024
34 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 6130 6113 -17

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.0MB 13.4MB -7.6MB
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 553 551 -2

References to deprecated APIs

id before after diff
securitySolution 450 448 -2

Total ESLint disabled count

id before after diff
securitySolution 639 637 -2

History

cc @logeekal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants