[Security Solution][Data Quality Dashboard][Serverless] add start/end time support for latest_results #199248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapral18
added
release_note:skip
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
kapral18
force-pushed
the
fix/DQD/191053-fix-incompatible-counts
branch
from
456a48e to
1a5a72f
Compare
kapral18
changed the title
kapral18
added
ci:cloud-deploy
kapral18
force-pushed
the
fix/DQD/191053-fix-incompatible-counts
branch
2 times, most recently
from
c5f4423 to
611e05f
Compare
kapral18
commented
Nov 7, 2024
There was a problem hiding this comment.
I will add the test, just noticed
kapral18
commented
Nov 7, 2024
Comment on lines
+85
to
+103
| const { startDate, endDate } = request.query; | ||
|
|
||
| let resultingIndices: string[] = []; | ||
|
|
||
| if (startDate && endDate) { | ||
| resultingIndices = resultingIndices.concat( | ||
| await getRangeFilteredIndices({ | ||
| client, | ||
| authorizedIndexNames, | ||
| startDate, | ||
| endDate, | ||
| logger, | ||
| pattern, | ||
| }) | ||
| ); | ||
| } else { | ||
| resultingIndices = authorizedIndexNames; | ||
| } | ||
|
|
There was a problem hiding this comment.
will add the test, just noticed
kapral18
force-pushed
the
fix/DQD/191053-fix-incompatible-counts
branch
from
bcf9539 to
21273b0
Compare
angorayc
approved these changes
Nov 7, 2024
… time support for latest_results addresses elastic#191053 - Introduce `defaultStartTime` and `defaultEndTime` props across data quality context and panels for fetching latest_results and align them with serverless default time range of last week - Update hooks to handle new time parameters and include them in storage results queries. - Modify server-side helpers and routes to process and filter indices based on the provided time range. - Update related tests to accommodate the new time parameters.
kapral18
force-pushed
the
fix/DQD/191053-fix-incompatible-counts
branch
from
21273b0 to
f732192
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @kapral18 |
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 7, 2024
… time support for latest_results (elastic#199248) addresses elastic#191053 - Introduce `defaultStartTime` and `defaultEndTime` props across data quality context and panels for fetching latest_results and align them with serverless default time range of last week - Update hooks to handle new time parameters and include them in storage results queries. - Modify server-side helpers and routes to process and filter indices based on the provided time range. - Update related tests to accommodate the new time parameters. (cherry picked from commit 1df04ae)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 7, 2024
…rt/end time support for latest_results (#199248) (#199385) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Data Quality Dashboard][Serverless] add start/end time support for latest_results (#199248)](#199248) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Karen Grigoryan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-07T17:42:31Z","message":"[Security Solution][Data Quality Dashboard][Serverless] add start/end time support for latest_results (#199248)\n\naddresses #191053\r\n\r\n- Introduce `defaultStartTime` and `defaultEndTime` props across data\r\nquality context and panels for fetching latest_results and align them\r\nwith serverless default time range of last week\r\n- Update hooks to handle new time parameters and include them in storage\r\nresults queries.\r\n- Modify server-side helpers and routes to process and filter indices\r\nbased on the provided time range.\r\n- Update related tests to accommodate the new time parameters.","sha":"1df04aef8d5859507c85a2ad37594075e9054b70","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Explore","backport:prev-minor","ci:cloud-deploy","ci:project-deploy-security"],"title":"[Security Solution][Data Quality Dashboard][Serverless] add start/end time support for latest_results","number":199248,"url":"https://github.com/elastic/kibana/pull/199248","mergeCommit":{"message":"[Security Solution][Data Quality Dashboard][Serverless] add start/end time support for latest_results (#199248)\n\naddresses #191053\r\n\r\n- Introduce `defaultStartTime` and `defaultEndTime` props across data\r\nquality context and panels for fetching latest_results and align them\r\nwith serverless default time range of last week\r\n- Update hooks to handle new time parameters and include them in storage\r\nresults queries.\r\n- Modify server-side helpers and routes to process and filter indices\r\nbased on the provided time range.\r\n- Update related tests to accommodate the new time parameters.","sha":"1df04aef8d5859507c85a2ad37594075e9054b70"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199248","number":199248,"mergeCommit":{"message":"[Security Solution][Data Quality Dashboard][Serverless] add start/end time support for latest_results (#199248)\n\naddresses #191053\r\n\r\n- Introduce `defaultStartTime` and `defaultEndTime` props across data\r\nquality context and panels for fetching latest_results and align them\r\nwith serverless default time range of last week\r\n- Update hooks to handle new time parameters and include them in storage\r\nresults queries.\r\n- Modify server-side helpers and routes to process and filter indices\r\nbased on the provided time range.\r\n- Update related tests to accommodate the new time parameters.","sha":"1df04aef8d5859507c85a2ad37594075e9054b70"}}]}] BACKPORT--> Co-authored-by: Karen Grigoryan <[email protected]>
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 8, 2024
… time support for latest_results (elastic#199248) addresses elastic#191053 - Introduce `defaultStartTime` and `defaultEndTime` props across data quality context and panels for fetching latest_results and align them with serverless default time range of last week - Update hooks to handle new time parameters and include them in storage results queries. - Modify server-side helpers and routes to process and filter indices based on the provided time range. - Update related tests to accommodate the new time parameters.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 8, 2024
… time support for latest_results (elastic#199248) addresses elastic#191053 - Introduce `defaultStartTime` and `defaultEndTime` props across data quality context and panels for fetching latest_results and align them with serverless default time range of last week - Update hooks to handle new time parameters and include them in storage results queries. - Modify server-side helpers and routes to process and filter indices based on the provided time range. - Update related tests to accommodate the new time parameters.
kapral18
added a commit
to kapral18/kibana
that referenced
this pull request
Nov 18, 2024
… time support for latest_results (elastic#199248) addresses elastic#191053 - Introduce `defaultStartTime` and `defaultEndTime` props across data quality context and panels for fetching latest_results and align them with serverless default time range of last week - Update hooks to handle new time parameters and include them in storage results queries. - Modify server-side helpers and routes to process and filter indices based on the provided time range. - Update related tests to accommodate the new time parameters. (cherry picked from commit 1df04ae)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kapral18
added a commit
that referenced
this pull request
Nov 18, 2024
…art/end time support for latest_results (#199248) (#200635) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Solution][Data Quality Dashboard][Serverless] add start/end time support for latest_results (#199248)](#199248) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Karen Grigoryan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-07T17:42:31Z","message":"[Security Solution][Data Quality Dashboard][Serverless] add start/end time support for latest_results (#199248)\n\naddresses #191053\r\n\r\n- Introduce `defaultStartTime` and `defaultEndTime` props across data\r\nquality context and panels for fetching latest_results and align them\r\nwith serverless default time range of last week\r\n- Update hooks to handle new time parameters and include them in storage\r\nresults queries.\r\n- Modify server-side helpers and routes to process and filter indices\r\nbased on the provided time range.\r\n- Update related tests to accommodate the new time parameters.","sha":"1df04aef8d5859507c85a2ad37594075e9054b70","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Explore","backport:prev-minor","ci:cloud-deploy","ci:project-deploy-security","v8.17.0"],"number":199248,"url":"https://github.com/elastic/kibana/pull/199248","mergeCommit":{"message":"[Security Solution][Data Quality Dashboard][Serverless] add start/end time support for latest_results (#199248)\n\naddresses #191053\r\n\r\n- Introduce `defaultStartTime` and `defaultEndTime` props across data\r\nquality context and panels for fetching latest_results and align them\r\nwith serverless default time range of last week\r\n- Update hooks to handle new time parameters and include them in storage\r\nresults queries.\r\n- Modify server-side helpers and routes to process and filter indices\r\nbased on the provided time range.\r\n- Update related tests to accommodate the new time parameters.","sha":"1df04aef8d5859507c85a2ad37594075e9054b70"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199248","number":199248,"mergeCommit":{"message":"[Security Solution][Data Quality Dashboard][Serverless] add start/end time support for latest_results (#199248)\n\naddresses #191053\r\n\r\n- Introduce `defaultStartTime` and `defaultEndTime` props across data\r\nquality context and panels for fetching latest_results and align them\r\nwith serverless default time range of last week\r\n- Update hooks to handle new time parameters and include them in storage\r\nresults queries.\r\n- Modify server-side helpers and routes to process and filter indices\r\nbased on the provided time range.\r\n- Update related tests to accommodate the new time parameters.","sha":"1df04aef8d5859507c85a2ad37594075e9054b70"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/199385","number":199385,"state":"MERGED","mergeCommit":{"sha":"de09e3af76d4bd1ce029830bd866e20b46e3aa9e","message":"[8.x] [Security Solution][Data Quality Dashboard][Serverless] add start/end time support for latest_results (#199248) (#199385)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Security Solution][Data Quality Dashboard][Serverless] add start/end\ntime support for latest_results\n(#199248)](https://github.com/elastic/kibana/pull/199248)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Karen\nGrigoryan\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-11-07T17:42:31Z\",\"message\":\"[Security\nSolution][Data Quality Dashboard][Serverless] add start/end time support\nfor latest_results (#199248)\\n\\naddresses #191053\\r\\n\\r\\n- Introduce\n`defaultStartTime` and `defaultEndTime` props across data\\r\\nquality\ncontext and panels for fetching latest_results and align them\\r\\nwith\nserverless default time range of last week\\r\\n- Update hooks to handle\nnew time parameters and include them in storage\\r\\nresults queries.\\r\\n-\nModify server-side helpers and routes to process and filter\nindices\\r\\nbased on the provided time range.\\r\\n- Update related tests\nto accommodate the new time\nparameters.\",\"sha\":\"1df04aef8d5859507c85a2ad37594075e9054b70\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"Team:Threat\nHunting\",\"Team:Threat\nHunting:Explore\",\"backport:prev-minor\",\"ci:cloud-deploy\",\"ci:project-deploy-security\"],\"title\":\"[Security\nSolution][Data Quality Dashboard][Serverless] add start/end time support\nfor\nlatest_results\",\"number\":199248,\"url\":\"https://github.com/elastic/kibana/pull/199248\",\"mergeCommit\":{\"message\":\"[Security\nSolution][Data Quality Dashboard][Serverless] add start/end time support\nfor latest_results (#199248)\\n\\naddresses #191053\\r\\n\\r\\n- Introduce\n`defaultStartTime` and `defaultEndTime` props across data\\r\\nquality\ncontext and panels for fetching latest_results and align them\\r\\nwith\nserverless default time range of last week\\r\\n- Update hooks to handle\nnew time parameters and include them in storage\\r\\nresults queries.\\r\\n-\nModify server-side helpers and routes to process and filter\nindices\\r\\nbased on the provided time range.\\r\\n- Update related tests\nto accommodate the new time\nparameters.\",\"sha\":\"1df04aef8d5859507c85a2ad37594075e9054b70\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/199248\",\"number\":199248,\"mergeCommit\":{\"message\":\"[Security\nSolution][Data Quality Dashboard][Serverless] add start/end time support\nfor latest_results (#199248)\\n\\naddresses #191053\\r\\n\\r\\n- Introduce\n`defaultStartTime` and `defaultEndTime` props across data\\r\\nquality\ncontext and panels for fetching latest_results and align them\\r\\nwith\nserverless default time range of last week\\r\\n- Update hooks to handle\nnew time parameters and include them in storage\\r\\nresults queries.\\r\\n-\nModify server-side helpers and routes to process and filter\nindices\\r\\nbased on the provided time range.\\r\\n- Update related tests\nto accommodate the new time\nparameters.\",\"sha\":\"1df04aef8d5859507c85a2ad37594075e9054b70\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Karen Grigoryan <[email protected]>"}}]}] BACKPORT-->
|
This PR didn't make it into the latest BC of v8.16.1. Updating the labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #191053
defaultStartTimeanddefaultEndTimeprops across data quality context and panels for fetching latest_results and align them with serverless default time range of last week