-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Agentless] Fix agentless global_data_tags #199247
[Agentless] Fix agentless global_data_tags #199247
Conversation
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
Pinging @elastic/fleet (Team:Fleet) |
💚 Build Succeeded
Metrics [docs]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work on finding the root cause @opauloh !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for digging into this! Appreciated!
Starting backport for target branches: 8.x |
(cherry picked from commit ef205b8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.x`: - [[Agentless] Fix agentless global_data_tags (#199247)](#199247) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paulo Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-07T14:32:47Z","message":"[Agentless] Fix agentless global_data_tags (#199247)","sha":"ef205b88888aa2240951de1a750b33dcec77c6b4","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Cloud Security","backport:version","v8.17.0"],"title":"[Agentless] Fix agentless global_data_tags","number":199247,"url":"https://github.com/elastic/kibana/pull/199247","mergeCommit":{"message":"[Agentless] Fix agentless global_data_tags (#199247)","sha":"ef205b88888aa2240951de1a750b33dcec77c6b4"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199247","number":199247,"mergeCommit":{"message":"[Agentless] Fix agentless global_data_tags (#199247)","sha":"ef205b88888aa2240951de1a750b33dcec77c6b4"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Paulo Silva <[email protected]>
Summary
It closes #199091
It fixes the Serverless Quality Gates that started to fail once a fix to enable sending the
global_data_tags
was merged here.In order to fix the issue, it updates the Agentless Tags to match the format expected in the Agentless Schema
Note: An investigation ticket will be added as part of the Reliability epic on how can we ensure the Agentless Schema and Kibana are in sync