[Fleet] Remove deprecated topics property for kafka output in favor of topic #199226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --update'
… src/core/server/integration_tests/ci_checks'
…nchaulet/kibana into feature-remove-deprecated-kafka-topics
nchaulet
added
release_note:breaking
backport:skip
|
Pinging @elastic/fleet (Team:Fleet) |
afharo
reviewed
Nov 7, 2024
| outputDoc.attributes.topic = outputDoc.attributes.topics?.filter((t) => !t.when)?.[0]?.topic; | ||
| } | ||
|
|
||
| delete outputDoc.attributes.topics; |
There was a problem hiding this comment.
The fact that we're removing this field makes it non-BWC. I wonder if we can perform the migration in 2 steps:
- Maintains both fields
- (In a couple of weeks) Deletes the deprecated
topicsarray
There was a problem hiding this comment.
@afharo since kibana 8.13 we already handle the fact that topics could not be here and the topic field is present, so I think we should not have any BWC issues
There was a problem hiding this comment.
let me know if you think this could still be an issue
There was a problem hiding this comment.
oh! if 8.13+ already uses the single topic field, then all good on my end. Approving
criamico
approved these changes
Nov 7, 2024
SiddharthMantri
approved these changes
Nov 8, 2024
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @nchaulet |
afharo
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #189746
Remove deprecated property
topicsfrom output APIs in response and requests(GET|POST|PUT) /api/fleet/outputsin favor of thetopicproperty in 9.0.The property was still used in Fleet UI and had to made a few change there.