-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Inventory][ECO] Use ControlGroupRenderer to filter by entity types #199174
Merged
cauemarcondes
merged 27 commits into
elastic:main
from
cauemarcondes:inventory-control-group-2
Nov 12, 2024
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
568cc99
lots of changes
cauemarcondes 4a488cf
more changes
cauemarcondes 8d604d7
filtering on grid
cauemarcondes 96bf645
updating
cauemarcondes 5a89904
refactoring
cauemarcondes 05519cd
fixing tests
cauemarcondes f358bf1
fixing ci
cauemarcondes d301233
removing kuery from alerts search
cauemarcondes 5ea6ad3
Merge branch 'main' into inventory-control-group-2
cauemarcondes 22ecb88
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 9118ccd
fixing ci
cauemarcondes d27b087
Merge branch 'inventory-control-group-2' of github.com:cauemarcondes/…
cauemarcondes 70b762e
Merge branch 'main' into inventory-control-group-2
cauemarcondes f29d810
fixing TS
cauemarcondes aeff7ac
addressing pr comments
cauemarcondes 5b412e9
feedback
cauemarcondes 2eab8b1
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 47c8755
reverting
cauemarcondes 0841578
Merge branch 'inventory-control-group-2' of github.com:cauemarcondes/…
cauemarcondes 94f4e5c
unused import
cauemarcondes 740845b
removing useless code
cauemarcondes 61ff739
fixing i18n
cauemarcondes df8eefc
Merge branch 'main' of github.com:elastic/kibana into inventory-contr…
cauemarcondes 405f7e9
Addressing PR comments
cauemarcondes ce078af
updating limits
cauemarcondes c94adec
unskipping test
cauemarcondes 827f89e
pr comments
cauemarcondes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
..._solution/infra/public/pages/metrics/hosts/components/search_bar/control_panels_config.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { ControlPanels } from '@kbn/observability-shared-plugin/public'; | ||
|
||
export const availableControlsPanels = { | ||
HOST_OS_NAME: 'host.os.name', | ||
CLOUD_PROVIDER: 'cloud.provider', | ||
SERVICE_NAME: 'service.name', | ||
}; | ||
|
||
export const controlPanelConfigs: ControlPanels = { | ||
[availableControlsPanels.HOST_OS_NAME]: { | ||
order: 0, | ||
width: 'medium', | ||
grow: false, | ||
type: 'optionsListControl', | ||
fieldName: availableControlsPanels.HOST_OS_NAME, | ||
title: 'Operating System', | ||
}, | ||
[availableControlsPanels.CLOUD_PROVIDER]: { | ||
order: 1, | ||
width: 'medium', | ||
grow: false, | ||
type: 'optionsListControl', | ||
fieldName: availableControlsPanels.CLOUD_PROVIDER, | ||
title: 'Cloud Provider', | ||
}, | ||
[availableControlsPanels.SERVICE_NAME]: { | ||
order: 2, | ||
width: 'medium', | ||
grow: false, | ||
type: 'optionsListControl', | ||
fieldName: availableControlsPanels.SERVICE_NAME, | ||
title: 'Service Name', | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 0 additions & 57 deletions
57
x-pack/plugins/observability_solution/inventory/common/entitites.test.ts
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there is anything we could do to avoid increasing the plugin size here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was thinking about this too. But this is out of the scope of this PR. I think this is a good topic for the
Devex-ui-wg
.