Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Search] Move `ConnectorDefinition` types and consts (#197676) #199167

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Summary

- Move types and consts for `ConnectorClientSideDefinition` and
`ConnectorServerSideDefinition` to the shared `kbn-search-connectors`
package
- Update ESS references to these values to use it from the package
- Remove them from the connectors plugin

(cherry picked from commit 8ed8cc9)
@navarone-feekery
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine kibanamachine merged commit c21ac81 into elastic:8.x Nov 8, 2024
21 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2318 2322 +4
searchConnectors 8 74 +66
serverlessSearch 286 290 +4
total +74

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/search-connectors 3929 3948 +19
searchConnectors 19 7 -12
total +7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +2.5KB
serverlessSearch 336.2KB 338.4KB +2.3KB
total +4.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
searchConnectors 3 0 -3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
searchConnectors 24.5KB 61.5KB +36.9KB
Unknown metric groups

API count

id before after diff
@kbn/search-connectors 3929 3948 +19
searchConnectors 19 7 -12
total +7

History

cc @navarone-feekery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants