[ML] Migrate ColorRangeLegend from SCSS to emotion. #199156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
65 tasks
ryankeairns
approved these changes
Nov 6, 2024
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 7, 2024
## Summary Part of elastic#140695 Migrates SCSS to emotion for ColorRangeLegend. <img src="https://github.com/user-attachments/assets/3444fa49-2ef2-4706-b15e-c3e8415c6293" /> <img src="https://github.com/user-attachments/assets/a79648a5-1230-41b6-b8f5-c1ff2dc9f996" width="75%" /> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) (cherry picked from commit 12dc8c1)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 7, 2024
…199274) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Migrate ColorRangeLegend from SCSS to emotion. (#199156)](#199156) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-07T09:37:20Z","message":"[ML] Migrate ColorRangeLegend from SCSS to emotion. (#199156)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/140695\r\n\r\nMigrates SCSS to emotion for ColorRangeLegend.\r\n\r\n<img\r\nsrc=\"https://github.com/user-attachments/assets/3444fa49-2ef2-4706-b15e-c3e8415c6293\"\r\n/>\r\n\r\n<img\r\nsrc=\"https://github.com/user-attachments/assets/a79648a5-1230-41b6-b8f5-c1ff2dc9f996\"\r\nwidth=\"75%\" />\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"12dc8c1bb84091d7c404b0e29654d56113fc5acb","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Feature:Data Frame Analytics","v9.0.0","backport:version","v8.17.0"],"title":"[ML] Migrate ColorRangeLegend from SCSS to emotion.","number":199156,"url":"https://github.com/elastic/kibana/pull/199156","mergeCommit":{"message":"[ML] Migrate ColorRangeLegend from SCSS to emotion. (#199156)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/140695\r\n\r\nMigrates SCSS to emotion for ColorRangeLegend.\r\n\r\n<img\r\nsrc=\"https://github.com/user-attachments/assets/3444fa49-2ef2-4706-b15e-c3e8415c6293\"\r\n/>\r\n\r\n<img\r\nsrc=\"https://github.com/user-attachments/assets/a79648a5-1230-41b6-b8f5-c1ff2dc9f996\"\r\nwidth=\"75%\" />\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"12dc8c1bb84091d7c404b0e29654d56113fc5acb"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199156","number":199156,"mergeCommit":{"message":"[ML] Migrate ColorRangeLegend from SCSS to emotion. (#199156)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/140695\r\n\r\nMigrates SCSS to emotion for ColorRangeLegend.\r\n\r\n<img\r\nsrc=\"https://github.com/user-attachments/assets/3444fa49-2ef2-4706-b15e-c3e8415c6293\"\r\n/>\r\n\r\n<img\r\nsrc=\"https://github.com/user-attachments/assets/a79648a5-1230-41b6-b8f5-c1ff2dc9f996\"\r\nwidth=\"75%\" />\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"12dc8c1bb84091d7c404b0e29654d56113fc5acb"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Walter Rafelsberger <[email protected]>
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 8, 2024
## Summary Part of elastic#140695 Migrates SCSS to emotion for ColorRangeLegend. <img src="https://github.com/user-attachments/assets/3444fa49-2ef2-4706-b15e-c3e8415c6293" /> <img src="https://github.com/user-attachments/assets/a79648a5-1230-41b6-b8f5-c1ff2dc9f996" width="75%" /> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #140695
Migrates SCSS to emotion for ColorRangeLegend.
Checklist