Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AI Assistant] Enable Search in Solution View #199137

Merged
merged 2 commits into from
Nov 7, 2024
Merged

[AI Assistant] Enable Search in Solution View #199137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
369b416
[AI Assistant] Enable Search in Solution View
sphilipse Nov 6, 2024
0be84a6
Fix tests
sphilipse Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions x-pack/plugins/spaces/server/capabilities/capabilities_switcher.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,14 +366,12 @@ describe('capabilitiesSwitcher', () => {
{
space.solution = 'oblt';

// It should disable enterpriseSearch and securitySolution features
// which correspond to feature_1 and feature_3
// It should disable securitySolution features
// which corresponds to feature_3
const result = await switcher(request, capabilities, false);

const expectedCapabilities = buildCapabilities();

expectedCapabilities.feature_1.bar = false;
expectedCapabilities.feature_1.foo = false;
expectedCapabilities.feature_3.bar = false;
expectedCapabilities.feature_3.foo = false;

Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/spaces/server/lib/utils/space_solution_disabled_features.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ describe('#withSpaceSolutionDisabledFeatures', () => {
});

describe('when the space solution is "oblt"', () => {
test('it removes the "search" and "security" features', () => {
test('it removes the "security" features', () => {
const spaceDisabledFeatures: string[] = [];
const spaceSolution = 'oblt';

Expand All @@ -68,7 +68,7 @@ describe('#withSpaceSolutionDisabledFeatures', () => {
spaceSolution
);

expect(result).toEqual(['feature2', 'feature3']);
expect(result).toEqual(['feature3']);
});
});

Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/spaces/server/lib/utils/space_solution_disabled_features.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ export function withSpaceSolutionDisabledFeatures(
]).filter((featureId) => !enabledFeaturesPerSolution.es.includes(featureId));
} else if (spaceSolution === 'oblt') {
disabledFeatureKeysFromSolution = getFeatureIdsForCategories(features, [
'enterpriseSearch',
'securitySolution',
]).filter((featureId) => !enabledFeaturesPerSolution.oblt.includes(featureId));
} else if (spaceSolution === 'security') {
Expand Down