[Expamples][Guided onboarding] - added missing EuiProvider to fix errors #199070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
tsullivan
reviewed
Nov 6, 2024
tsullivan
approved these changes
Nov 6, 2024
💚 Build Succeeded
Metrics [docs]
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 6, 2024
…ors (elastic#199070) ## Summary This PR fixes a missing `EuiProvider` within the guided onboarding example. Currently the app is barely usable as it throws hundreds or even thousands of errors which make the page extremely slow. #### Before fix https://github.com/user-attachments/assets/87b8252a-82ac-4094-8adf-3cd4c12236ef #### After fix https://github.com/user-attachments/assets/0382192b-94b7-4d4b-bada-2d438a750b14 ### Notes **_This PR does NOT fix all the console errors, that's why you see a couple of errors in the console still on the second video above. It just fixes the bare minimum to make the app at least usable._** --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 833658f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 6, 2024
…ix errors (#199070) (#199076) # Backport This will backport the following commits from `main` to `8.x`: - [[Expamples][Guided onboarding] - added missing EuiProvider to fix errors (#199070)](#199070) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-06T02:17:16Z","message":"[Expamples][Guided onboarding] - added missing EuiProvider to fix errors (#199070)\n\n## Summary\r\n\r\nThis PR fixes a missing `EuiProvider` within the guided onboarding\r\nexample. Currently the app is barely usable as it throws hundreds or\r\neven thousands of errors which make the page extremely slow.\r\n\r\n#### Before fix\r\n\r\n\r\nhttps://github.com/user-attachments/assets/87b8252a-82ac-4094-8adf-3cd4c12236ef\r\n\r\n#### After fix\r\n\r\n\r\nhttps://github.com/user-attachments/assets/0382192b-94b7-4d4b-bada-2d438a750b14\r\n\r\n\r\n### Notes\r\n**_This PR does NOT fix all the console errors, that's why you see a\r\ncouple of errors in the console still on the second video above. It just\r\nfixes the bare minimum to make the app at least usable._**\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"833658f094bfec06b1bfdb34c32376cbb5862f53","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.17.0"],"title":"[Expamples][Guided onboarding] - added missing EuiProvider to fix errors","number":199070,"url":"https://github.com/elastic/kibana/pull/199070","mergeCommit":{"message":"[Expamples][Guided onboarding] - added missing EuiProvider to fix errors (#199070)\n\n## Summary\r\n\r\nThis PR fixes a missing `EuiProvider` within the guided onboarding\r\nexample. Currently the app is barely usable as it throws hundreds or\r\neven thousands of errors which make the page extremely slow.\r\n\r\n#### Before fix\r\n\r\n\r\nhttps://github.com/user-attachments/assets/87b8252a-82ac-4094-8adf-3cd4c12236ef\r\n\r\n#### After fix\r\n\r\n\r\nhttps://github.com/user-attachments/assets/0382192b-94b7-4d4b-bada-2d438a750b14\r\n\r\n\r\n### Notes\r\n**_This PR does NOT fix all the console errors, that's why you see a\r\ncouple of errors in the console still on the second video above. It just\r\nfixes the bare minimum to make the app at least usable._**\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"833658f094bfec06b1bfdb34c32376cbb5862f53"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199070","number":199070,"mergeCommit":{"message":"[Expamples][Guided onboarding] - added missing EuiProvider to fix errors (#199070)\n\n## Summary\r\n\r\nThis PR fixes a missing `EuiProvider` within the guided onboarding\r\nexample. Currently the app is barely usable as it throws hundreds or\r\neven thousands of errors which make the page extremely slow.\r\n\r\n#### Before fix\r\n\r\n\r\nhttps://github.com/user-attachments/assets/87b8252a-82ac-4094-8adf-3cd4c12236ef\r\n\r\n#### After fix\r\n\r\n\r\nhttps://github.com/user-attachments/assets/0382192b-94b7-4d4b-bada-2d438a750b14\r\n\r\n\r\n### Notes\r\n**_This PR does NOT fix all the console errors, that's why you see a\r\ncouple of errors in the console still on the second video above. It just\r\nfixes the bare minimum to make the app at least usable._**\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"833658f094bfec06b1bfdb34c32376cbb5862f53"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <[email protected]>
mgadewoll
pushed a commit
to mgadewoll/kibana
that referenced
this pull request
Nov 7, 2024
…ors (elastic#199070) ## Summary This PR fixes a missing `EuiProvider` within the guided onboarding example. Currently the app is barely usable as it throws hundreds or even thousands of errors which make the page extremely slow. #### Before fix https://github.com/user-attachments/assets/87b8252a-82ac-4094-8adf-3cd4c12236ef #### After fix https://github.com/user-attachments/assets/0382192b-94b7-4d4b-bada-2d438a750b14 ### Notes **_This PR does NOT fix all the console errors, that's why you see a couple of errors in the console still on the second video above. It just fixes the bare minimum to make the app at least usable._** --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a missing
EuiProviderwithin the guided onboarding example. Currently the app is barely usable as it throws hundreds or even thousands of errors which make the page extremely slow.Before fix
Screen.Recording.2024-11-05.at.5.28.10.PM.mov
After fix
Screen.Recording.2024-11-05.at.5.26.04.PM.mov
Notes
This PR does NOT fix all the console errors, that's why you see a couple of errors in the console still on the second video above. It just fixes the bare minimum to make the app at least usable.