Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip _shared_links.ts functional test #198947

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Unskip _shared_links.ts functional test #198947

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d966409
Unskip functional test
kertal Nov 5, 2024
7dec0d8
Update _shared_links.ts
kertal Nov 6, 2024
8598f28
Merge branch '7.17' into discover-unskip-functional-test-7
kertal Nov 6, 2024
c6b4438
Update _shared_links.ts
kertal Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions test/functional/apps/discover/_shared_links.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const toasts = getService('toasts');
const deployment = getService('deployment');

// Failing: See https://github.com/elastic/kibana/issues/196627
describe.skip('shared links', function describeIndexTests() {
describe('shared links', function describeIndexTests() {
let baseUrl: string;

async function setup({ storeStateInSessionStorage }: { storeStateInSessionStorage: boolean }) {
Expand Down Expand Up @@ -179,7 +178,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await retry.waitFor('discover to open', async () => {
const resolvedUrl = await browser.getCurrentUrl();
expect(resolvedUrl).to.match(/discover/);
const { message } = await toasts.getErrorToast();
// the toast we aiming to check is usually the 2nd one, but it can also be the first one
// there are 3 same toasts here which was resolved in the next major version
// the workaround to check for the 2nd toast, which allows the test to always pass
const { message } = await toasts.getErrorToast(2);
expect(message).to.contain(
'Unable to completely restore the URL, be sure to use the share functionality.'
);
Expand Down