Improves cleanup in spaces data functional test #198921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
|
jeramysoucy
added
Team:Security
|
Pinging @elastic/kibana-security (Team:Security) |
jeramysoucy
added
release_note:skip
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7335[✅] x-pack/test/functional/apps/spaces/config.ts: 200/200 tests passed. |
SiddharthMantri
approved these changes
Nov 5, 2024
|
Starting backport for target branches: 7.17, 8.15, 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 5, 2024
Closes elastic#52714 ## Summary Uses the sample data FTR service to remove the sample data via API during cleanup. Previously, the after block only removed the sample data from one space and attempted to rely on an esArchiver call to clean up remaining data later on. As the scope of the test does not use the esArchiver any longer, it seems more appropriate to remove the sample data more deterministically. ### Flaky test runner - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7335 (cherry picked from commit b5c8ed7)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 5, 2024
Closes elastic#52714 ## Summary Uses the sample data FTR service to remove the sample data via API during cleanup. Previously, the after block only removed the sample data from one space and attempted to rely on an esArchiver call to clean up remaining data later on. As the scope of the test does not use the esArchiver any longer, it seems more appropriate to remove the sample data more deterministically. ### Flaky test runner - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7335 (cherry picked from commit b5c8ed7)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 5, 2024
Closes elastic#52714 ## Summary Uses the sample data FTR service to remove the sample data via API during cleanup. Previously, the after block only removed the sample data from one space and attempted to rely on an esArchiver call to clean up remaining data later on. As the scope of the test does not use the esArchiver any longer, it seems more appropriate to remove the sample data more deterministically. ### Flaky test runner - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7335 (cherry picked from commit b5c8ed7)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 5, 2024
) # Backport This will backport the following commits from `main` to `8.x`: - [Improves cleanup in spaces data functional test (#198921)](#198921) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jeramy Soucy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T16:31:25Z","message":"Improves cleanup in spaces data functional test (#198921)\n\nCloses #52714\r\n\r\n## Summary\r\n\r\nUses the sample data FTR service to remove the sample data via API\r\nduring cleanup. Previously, the after block only removed the sample data\r\nfrom one space and attempted to rely on an esArchiver call to clean up\r\nremaining data later on. As the scope of the test does not use the\r\nesArchiver any longer, it seems more appropriate to remove the sample\r\ndata more deterministically.\r\n\r\n### Flaky test runner\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7335","sha":"b5c8ed7b5c8883993a534626384fe92b728e850c","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","v9.0.0","backport:all-open","FTR"],"title":"Improves cleanup in spaces data functional test","number":198921,"url":"https://github.com/elastic/kibana/pull/198921","mergeCommit":{"message":"Improves cleanup in spaces data functional test (#198921)\n\nCloses #52714\r\n\r\n## Summary\r\n\r\nUses the sample data FTR service to remove the sample data via API\r\nduring cleanup. Previously, the after block only removed the sample data\r\nfrom one space and attempted to rely on an esArchiver call to clean up\r\nremaining data later on. As the scope of the test does not use the\r\nesArchiver any longer, it seems more appropriate to remove the sample\r\ndata more deterministically.\r\n\r\n### Flaky test runner\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7335","sha":"b5c8ed7b5c8883993a534626384fe92b728e850c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198921","number":198921,"mergeCommit":{"message":"Improves cleanup in spaces data functional test (#198921)\n\nCloses #52714\r\n\r\n## Summary\r\n\r\nUses the sample data FTR service to remove the sample data via API\r\nduring cleanup. Previously, the after block only removed the sample data\r\nfrom one space and attempted to rely on an esArchiver call to clean up\r\nremaining data later on. As the scope of the test does not use the\r\nesArchiver any longer, it seems more appropriate to remove the sample\r\ndata more deterministically.\r\n\r\n### Flaky test runner\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7335","sha":"b5c8ed7b5c8883993a534626384fe92b728e850c"}}]}] BACKPORT--> Co-authored-by: Jeramy Soucy <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 5, 2024
…9022) # Backport This will backport the following commits from `main` to `8.15`: - [Improves cleanup in spaces data functional test (#198921)](#198921) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jeramy Soucy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T16:31:25Z","message":"Improves cleanup in spaces data functional test (#198921)\n\nCloses #52714\r\n\r\n## Summary\r\n\r\nUses the sample data FTR service to remove the sample data via API\r\nduring cleanup. Previously, the after block only removed the sample data\r\nfrom one space and attempted to rely on an esArchiver call to clean up\r\nremaining data later on. As the scope of the test does not use the\r\nesArchiver any longer, it seems more appropriate to remove the sample\r\ndata more deterministically.\r\n\r\n### Flaky test runner\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7335","sha":"b5c8ed7b5c8883993a534626384fe92b728e850c","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","v9.0.0","backport:all-open","FTR"],"title":"Improves cleanup in spaces data functional test","number":198921,"url":"https://github.com/elastic/kibana/pull/198921","mergeCommit":{"message":"Improves cleanup in spaces data functional test (#198921)\n\nCloses #52714\r\n\r\n## Summary\r\n\r\nUses the sample data FTR service to remove the sample data via API\r\nduring cleanup. Previously, the after block only removed the sample data\r\nfrom one space and attempted to rely on an esArchiver call to clean up\r\nremaining data later on. As the scope of the test does not use the\r\nesArchiver any longer, it seems more appropriate to remove the sample\r\ndata more deterministically.\r\n\r\n### Flaky test runner\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7335","sha":"b5c8ed7b5c8883993a534626384fe92b728e850c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198921","number":198921,"mergeCommit":{"message":"Improves cleanup in spaces data functional test (#198921)\n\nCloses #52714\r\n\r\n## Summary\r\n\r\nUses the sample data FTR service to remove the sample data via API\r\nduring cleanup. Previously, the after block only removed the sample data\r\nfrom one space and attempted to rely on an esArchiver call to clean up\r\nremaining data later on. As the scope of the test does not use the\r\nesArchiver any longer, it seems more appropriate to remove the sample\r\ndata more deterministically.\r\n\r\n### Flaky test runner\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7335","sha":"b5c8ed7b5c8883993a534626384fe92b728e850c"}}]}] BACKPORT--> Co-authored-by: Jeramy Soucy <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 5, 2024
…9023) # Backport This will backport the following commits from `main` to `8.16`: - [Improves cleanup in spaces data functional test (#198921)](#198921) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jeramy Soucy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T16:31:25Z","message":"Improves cleanup in spaces data functional test (#198921)\n\nCloses #52714\r\n\r\n## Summary\r\n\r\nUses the sample data FTR service to remove the sample data via API\r\nduring cleanup. Previously, the after block only removed the sample data\r\nfrom one space and attempted to rely on an esArchiver call to clean up\r\nremaining data later on. As the scope of the test does not use the\r\nesArchiver any longer, it seems more appropriate to remove the sample\r\ndata more deterministically.\r\n\r\n### Flaky test runner\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7335","sha":"b5c8ed7b5c8883993a534626384fe92b728e850c","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","v9.0.0","backport:all-open","FTR"],"title":"Improves cleanup in spaces data functional test","number":198921,"url":"https://github.com/elastic/kibana/pull/198921","mergeCommit":{"message":"Improves cleanup in spaces data functional test (#198921)\n\nCloses #52714\r\n\r\n## Summary\r\n\r\nUses the sample data FTR service to remove the sample data via API\r\nduring cleanup. Previously, the after block only removed the sample data\r\nfrom one space and attempted to rely on an esArchiver call to clean up\r\nremaining data later on. As the scope of the test does not use the\r\nesArchiver any longer, it seems more appropriate to remove the sample\r\ndata more deterministically.\r\n\r\n### Flaky test runner\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7335","sha":"b5c8ed7b5c8883993a534626384fe92b728e850c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198921","number":198921,"mergeCommit":{"message":"Improves cleanup in spaces data functional test (#198921)\n\nCloses #52714\r\n\r\n## Summary\r\n\r\nUses the sample data FTR service to remove the sample data via API\r\nduring cleanup. Previously, the after block only removed the sample data\r\nfrom one space and attempted to rely on an esArchiver call to clean up\r\nremaining data later on. As the scope of the test does not use the\r\nesArchiver any longer, it seems more appropriate to remove the sample\r\ndata more deterministically.\r\n\r\n### Flaky test runner\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7335","sha":"b5c8ed7b5c8883993a534626384fe92b728e850c"}}]}] BACKPORT--> Co-authored-by: Jeramy Soucy <[email protected]>
mgadewoll
pushed a commit
to mgadewoll/kibana
that referenced
this pull request
Nov 7, 2024
Closes elastic#52714 ## Summary Uses the sample data FTR service to remove the sample data via API during cleanup. Previously, the after block only removed the sample data from one space and attempted to rely on an esArchiver call to clean up remaining data later on. As the scope of the test does not use the esArchiver any longer, it seems more appropriate to remove the sample data more deterministically. ### Flaky test runner - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52714
Summary
Uses the sample data FTR service to remove the sample data via API during cleanup. Previously, the after block only removed the sample data from one space and attempted to rely on an esArchiver call to clean up remaining data later on. As the scope of the test does not use the esArchiver any longer, it seems more appropriate to remove the sample data more deterministically.
Flaky test runner