-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability] [Alerts table] Fix cannot display alerts error #198914
Merged
benakansara
merged 2 commits into
elastic:main
from
benakansara:fix/cannot-display-alerts
Nov 5, 2024
Merged
[Observability] [Alerts table] Fix cannot display alerts error #198914
benakansara
merged 2 commits into
elastic:main
from
benakansara:fix/cannot-display-alerts
Nov 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benakansara
changed the title
[Observability] [Alerts table] Fix Cannot display alerts
[Observability] [Alerts table] Fix cannot display alerts error
Nov 5, 2024
benakansara
added
release_note:skip
Skip the PR/issue when compiling release notes
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
labels
Nov 5, 2024
maryam-saeidi
approved these changes
Nov 5, 2024
botelastic
bot
added
ci:project-deploy-observability
Create an Observability project
Team:obs-ux-management
Observability Management User Experience Team
labels
Nov 5, 2024
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
benakansara
added
v9.0.0
v8.16.0
backport:version
Backport to applied version labels
v8.17.0
v8.15.4
and removed
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
labels
Nov 5, 2024
Starting backport for target branches: 8.15, 8.16, 8.x |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
cc @benakansara |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 5, 2024
…ic#198914) Resolves elastic#198912 ### Testing - Create ES query rule in Observability - Open Alert flyout of the ES query alert - Verify that Alert flyout opens as expected (cherry picked from commit f8c01d4)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 5, 2024
…ic#198914) Resolves elastic#198912 ### Testing - Create ES query rule in Observability - Open Alert flyout of the ES query alert - Verify that Alert flyout opens as expected (cherry picked from commit f8c01d4)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 5, 2024
…ic#198914) Resolves elastic#198912 ### Testing - Create ES query rule in Observability - Open Alert flyout of the ES query alert - Verify that Alert flyout opens as expected (cherry picked from commit f8c01d4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 5, 2024
…#198914) (#198938) # Backport This will backport the following commits from `main` to `8.15`: - [[Observability] [Alerts table] Fix cannot display alerts error (#198914)](#198914) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bena Kansara","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T12:57:32Z","message":"[Observability] [Alerts table] Fix cannot display alerts error (#198914)\n\nResolves https://github.com/elastic/kibana/issues/198912\r\n\r\n### Testing\r\n- Create ES query rule in Observability\r\n- Open Alert flyout of the ES query alert\r\n- Verify that Alert flyout opens as expected","sha":"f8c01d41d2dc6c4c4d096c485b48dc7decafd873","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0","backport:version","v8.17.0","v8.15.4"],"title":"[Observability] [Alerts table] Fix cannot display alerts error","number":198914,"url":"https://github.com/elastic/kibana/pull/198914","mergeCommit":{"message":"[Observability] [Alerts table] Fix cannot display alerts error (#198914)\n\nResolves https://github.com/elastic/kibana/issues/198912\r\n\r\n### Testing\r\n- Create ES query rule in Observability\r\n- Open Alert flyout of the ES query alert\r\n- Verify that Alert flyout opens as expected","sha":"f8c01d41d2dc6c4c4d096c485b48dc7decafd873"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198914","number":198914,"mergeCommit":{"message":"[Observability] [Alerts table] Fix cannot display alerts error (#198914)\n\nResolves https://github.com/elastic/kibana/issues/198912\r\n\r\n### Testing\r\n- Create ES query rule in Observability\r\n- Open Alert flyout of the ES query alert\r\n- Verify that Alert flyout opens as expected","sha":"f8c01d41d2dc6c4c4d096c485b48dc7decafd873"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Bena Kansara <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 5, 2024
…198914) (#198940) # Backport This will backport the following commits from `main` to `8.x`: - [[Observability] [Alerts table] Fix cannot display alerts error (#198914)](#198914) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bena Kansara","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T12:57:32Z","message":"[Observability] [Alerts table] Fix cannot display alerts error (#198914)\n\nResolves https://github.com/elastic/kibana/issues/198912\r\n\r\n### Testing\r\n- Create ES query rule in Observability\r\n- Open Alert flyout of the ES query alert\r\n- Verify that Alert flyout opens as expected","sha":"f8c01d41d2dc6c4c4d096c485b48dc7decafd873","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0","backport:version","v8.17.0","v8.15.4"],"title":"[Observability] [Alerts table] Fix cannot display alerts error","number":198914,"url":"https://github.com/elastic/kibana/pull/198914","mergeCommit":{"message":"[Observability] [Alerts table] Fix cannot display alerts error (#198914)\n\nResolves https://github.com/elastic/kibana/issues/198912\r\n\r\n### Testing\r\n- Create ES query rule in Observability\r\n- Open Alert flyout of the ES query alert\r\n- Verify that Alert flyout opens as expected","sha":"f8c01d41d2dc6c4c4d096c485b48dc7decafd873"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198914","number":198914,"mergeCommit":{"message":"[Observability] [Alerts table] Fix cannot display alerts error (#198914)\n\nResolves https://github.com/elastic/kibana/issues/198912\r\n\r\n### Testing\r\n- Create ES query rule in Observability\r\n- Open Alert flyout of the ES query alert\r\n- Verify that Alert flyout opens as expected","sha":"f8c01d41d2dc6c4c4d096c485b48dc7decafd873"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Bena Kansara <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 5, 2024
…#198914) (#198939) # Backport This will backport the following commits from `main` to `8.16`: - [[Observability] [Alerts table] Fix cannot display alerts error (#198914)](#198914) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bena Kansara","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T12:57:32Z","message":"[Observability] [Alerts table] Fix cannot display alerts error (#198914)\n\nResolves https://github.com/elastic/kibana/issues/198912\r\n\r\n### Testing\r\n- Create ES query rule in Observability\r\n- Open Alert flyout of the ES query alert\r\n- Verify that Alert flyout opens as expected","sha":"f8c01d41d2dc6c4c4d096c485b48dc7decafd873","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0","backport:version","v8.17.0","v8.15.4"],"title":"[Observability] [Alerts table] Fix cannot display alerts error","number":198914,"url":"https://github.com/elastic/kibana/pull/198914","mergeCommit":{"message":"[Observability] [Alerts table] Fix cannot display alerts error (#198914)\n\nResolves https://github.com/elastic/kibana/issues/198912\r\n\r\n### Testing\r\n- Create ES query rule in Observability\r\n- Open Alert flyout of the ES query alert\r\n- Verify that Alert flyout opens as expected","sha":"f8c01d41d2dc6c4c4d096c485b48dc7decafd873"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198914","number":198914,"mergeCommit":{"message":"[Observability] [Alerts table] Fix cannot display alerts error (#198914)\n\nResolves https://github.com/elastic/kibana/issues/198912\r\n\r\n### Testing\r\n- Create ES query rule in Observability\r\n- Open Alert flyout of the ES query alert\r\n- Verify that Alert flyout opens as expected","sha":"f8c01d41d2dc6c4c4d096c485b48dc7decafd873"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Bena Kansara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
ci:project-deploy-observability
Create an Observability project
release_note:skip
Skip the PR/issue when compiling release notes
Team:obs-ux-management
Observability Management User Experience Team
v8.15.4
v8.16.0
v8.17.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #198912
Testing