[Security GenAI] Fix and un-skip Knowledge Base Integration Tests #198861
+22
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e40pud
added
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Looks good, will approve pending flakey test runner results! https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7329 |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7329[✅] x-pack/test/security_solution_api_integration/test_suites/genai/knowledge_base/entries/trial_license_complete_tier/configs/ess.config.ts: 50/50 tests passed. |
stephmilovic
approved these changes
Nov 4, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
cc @e40pud |
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 5, 2024
…astic#198861) ## Summary This is a followup to elastic#198178 where we skipped KB integration tests. We enable it with this PR. Since it takes a lot of time to setup all Security Labs docs, the idea is to skip installing those docs when it is not needed. For these tests we need to make sure that inference endpoint is setup correctly - labs docs are not required in this case. cc @stephmilovic (cherry picked from commit 69c1e5a)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 5, 2024
…astic#198861) ## Summary This is a followup to elastic#198178 where we skipped KB integration tests. We enable it with this PR. Since it takes a lot of time to setup all Security Labs docs, the idea is to skip installing those docs when it is not needed. For these tests we need to make sure that inference endpoint is setup correctly - labs docs are not required in this case. cc @stephmilovic (cherry picked from commit 69c1e5a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 5, 2024
…sts (#198861) (#198889) # Backport This will backport the following commits from `main` to `8.16`: - [[Security GenAI] Fix and un-skip Knowledge Base Integration Tests (#198861)](#198861) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T07:40:59Z","message":"[Security GenAI] Fix and un-skip Knowledge Base Integration Tests (#198861)\n\n## Summary\r\n\r\nThis is a followup to https://github.com/elastic/kibana/pull/198178\r\nwhere we skipped KB integration tests. We enable it with this PR.\r\n\r\nSince it takes a lot of time to setup all Security Labs docs, the idea\r\nis to skip installing those docs when it is not needed. For these tests\r\nwe need to make sure that inference endpoint is setup correctly - labs\r\ndocs are not required in this case.\r\n\r\ncc @stephmilovic","sha":"69c1e5a7dda2708773dfeed2314b0ef74f4537ee","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","backport:version","v8.17.0","v8.16.1"],"title":"[Security GenAI] Fix and un-skip Knowledge Base Integration Tests","number":198861,"url":"https://github.com/elastic/kibana/pull/198861","mergeCommit":{"message":"[Security GenAI] Fix and un-skip Knowledge Base Integration Tests (#198861)\n\n## Summary\r\n\r\nThis is a followup to https://github.com/elastic/kibana/pull/198178\r\nwhere we skipped KB integration tests. We enable it with this PR.\r\n\r\nSince it takes a lot of time to setup all Security Labs docs, the idea\r\nis to skip installing those docs when it is not needed. For these tests\r\nwe need to make sure that inference endpoint is setup correctly - labs\r\ndocs are not required in this case.\r\n\r\ncc @stephmilovic","sha":"69c1e5a7dda2708773dfeed2314b0ef74f4537ee"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198861","number":198861,"mergeCommit":{"message":"[Security GenAI] Fix and un-skip Knowledge Base Integration Tests (#198861)\n\n## Summary\r\n\r\nThis is a followup to https://github.com/elastic/kibana/pull/198178\r\nwhere we skipped KB integration tests. We enable it with this PR.\r\n\r\nSince it takes a lot of time to setup all Security Labs docs, the idea\r\nis to skip installing those docs when it is not needed. For these tests\r\nwe need to make sure that inference endpoint is setup correctly - labs\r\ndocs are not required in this case.\r\n\r\ncc @stephmilovic","sha":"69c1e5a7dda2708773dfeed2314b0ef74f4537ee"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 5, 2024
…ts (#198861) (#198890) # Backport This will backport the following commits from `main` to `8.x`: - [[Security GenAI] Fix and un-skip Knowledge Base Integration Tests (#198861)](#198861) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T07:40:59Z","message":"[Security GenAI] Fix and un-skip Knowledge Base Integration Tests (#198861)\n\n## Summary\r\n\r\nThis is a followup to https://github.com/elastic/kibana/pull/198178\r\nwhere we skipped KB integration tests. We enable it with this PR.\r\n\r\nSince it takes a lot of time to setup all Security Labs docs, the idea\r\nis to skip installing those docs when it is not needed. For these tests\r\nwe need to make sure that inference endpoint is setup correctly - labs\r\ndocs are not required in this case.\r\n\r\ncc @stephmilovic","sha":"69c1e5a7dda2708773dfeed2314b0ef74f4537ee","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","backport:version","v8.17.0","v8.16.1"],"title":"[Security GenAI] Fix and un-skip Knowledge Base Integration Tests","number":198861,"url":"https://github.com/elastic/kibana/pull/198861","mergeCommit":{"message":"[Security GenAI] Fix and un-skip Knowledge Base Integration Tests (#198861)\n\n## Summary\r\n\r\nThis is a followup to https://github.com/elastic/kibana/pull/198178\r\nwhere we skipped KB integration tests. We enable it with this PR.\r\n\r\nSince it takes a lot of time to setup all Security Labs docs, the idea\r\nis to skip installing those docs when it is not needed. For these tests\r\nwe need to make sure that inference endpoint is setup correctly - labs\r\ndocs are not required in this case.\r\n\r\ncc @stephmilovic","sha":"69c1e5a7dda2708773dfeed2314b0ef74f4537ee"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198861","number":198861,"mergeCommit":{"message":"[Security GenAI] Fix and un-skip Knowledge Base Integration Tests (#198861)\n\n## Summary\r\n\r\nThis is a followup to https://github.com/elastic/kibana/pull/198178\r\nwhere we skipped KB integration tests. We enable it with this PR.\r\n\r\nSince it takes a lot of time to setup all Security Labs docs, the idea\r\nis to skip installing those docs when it is not needed. For these tests\r\nwe need to make sure that inference endpoint is setup correctly - labs\r\ndocs are not required in this case.\r\n\r\ncc @stephmilovic","sha":"69c1e5a7dda2708773dfeed2314b0ef74f4537ee"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a followup to #198178 where we skipped KB integration tests. We enable it with this PR.
Since it takes a lot of time to setup all Security Labs docs, the idea is to skip installing those docs when it is not needed. For these tests we need to make sure that inference endpoint is setup correctly - labs docs are not required in this case.
cc @stephmilovic