Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.17] encoding fixes #198857

Merged
merged 1 commit into from
Nov 5, 2024
Merged

[7.17] encoding fixes #198857

merged 1 commit into from
Nov 5, 2024

Conversation

bryce-b
Copy link
Contributor

@bryce-b bryce-b commented Nov 4, 2024 •
edited
Loading

Summary

Fixes encoding errors where only the first replace match was getting replaced.

@bryce-b bryce-b marked this pull request as ready for review November 4, 2024 20:52
@bryce-b bryce-b changed the title Added fixes for code scans [7.17][fixes] Corrects encoding errors Nov 4, 2024
@bryce-b bryce-b changed the title [7.17][fixes] Corrects encoding errors [7.17] encoding fixes Nov 4, 2024
@bryce-b bryce-b added release_note:fix Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Nov 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

@bryce-b bryce-b added the backport:skip This commit does not require backporting label Nov 4, 2024
cauemarcondes
cauemarcondes approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryce-b bryce-b merged commit 7e68e2c into elastic:7.17 Nov 5, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:fix Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryce-b @elasticmachine @cauemarcondes