Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] fix: [Stateful: Indices: Overview page] Wrong focus order after generating API key on the dialog (#197212) #198823

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…ating API key on the dialog (elastic#197212)

Closes elastic#196490

## Description
The focus order should be clear and sequential. Changes in the dialog
should be announced so that users, especially those using assistive
technologies, can navigate easily and understand what is happening.

## What was changed:

1. `generate_api_key_modal/modal.tsx` was slightly updated to be more
accessibility (a11y) friendly:
- To differentiate the two UI states, we now use two colors for the
panel: `primary` for the initial state and `success` when the API key is
generated.
- An `EuiCallOut` with `role="alert"` was added to announce status
updates for screen reader users.
- After creating an API key, the focus now moves to the `Download API
key` button.

## Screen

https://github.com/user-attachments/assets/24d13648-390a-4fe6-9202-d808c38c3c5c
(cherry picked from commit 198fbcf)
@kibanamachine kibanamachine merged commit feca08a into elastic:8.x Nov 4, 2024
28 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #12 / MetricsUI Endpoints GET /infra/services "after all" hook in "GET /infra/services"
  • [job] [logs] FTR Configs #12 / MetricsUI Endpoints GET /infra/services "before all" hook in "GET /infra/services"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +763.0B

cc @alexwizp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants