Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Fleet] Add <type>@custom component template to integrations index te… (#192731) #198808

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine enabled auto-merge (squash) November 4, 2024 15:30
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

elastic#192731)

## Summary

Relates elastic#190730

This PR adds a `<type>@Custom `component template to integrations index
template's `composed_of` array.

### Testing

Integration install/update should be tested.

From my manual testing, Fleet seems to behave normally and the new
component template is added to the `composed_of` array. For example, the
output of `GET /_index_template/logs-system.auth` is:
```json
{
  "index_templates": [
    {
      "name": "logs-system.auth",
      "index_template": {
        "index_patterns": [
          "logs-system.auth-*"
        ],
        "template": {
          "settings": {},
          "mappings": {
            "_meta": {
              "package": {
                "name": "system"
              },
              "managed_by": "fleet",
              "managed": true
            }
          }
        },
        "composed_of": [
          "logs@mappings",
          "logs@settings",
          "logs-system.auth@package",
          "logs@custom",
          "logs-system.auth@custom",
          "ecs@mappings",
          ".fleet_globals-1",
          ".fleet_agent_id_verification-1"
        ],
        "priority": 200,
        "_meta": {
          "package": {
            "name": "system"
          },
          "managed_by": "fleet",
          "managed": true
        },
        "data_stream": {
          "hidden": false,
          "allow_custom_routing": false,
          "failure_store": false
        },
        "ignore_missing_component_templates": [
          "logs@custom",
          "logs-system.auth@custom"
        ]
      }
    }
  ]
}
```

### Screenshot

<img width="956" alt="Screenshot 2024-09-19 at 16 44 57"
src="https://github.com/user-attachments/assets/7e1d8e67-1d78-45a7-bc8d-8e509f1a2533">

<img width="956" alt="Screenshot 2024-09-19 at 17 04 45"
src="https://github.com/user-attachments/assets/8b6bbaf3-34b7-4169-8ca8-2bc6a38fe60d">

### Checklist

- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

(cherry picked from commit c8ff7ea)
@kibanamachine kibanamachine force-pushed the backport/8.x/pr-192731 branch from 4037d6b to 9bb65d7 Compare November 4, 2024 15:31
@kibanamachine kibanamachine merged commit 8fdcef5 into elastic:8.x Nov 4, 2024
24 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @jillguyonnet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants