Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] unskip tests that were failing on chrome 128, 129 #198807

Closed
wants to merge 2 commits into from

Conversation

delanni
Copy link
Contributor

@delanni delanni commented Nov 4, 2024

Summary

These tests were skipped so that we could upgrade to Chrome 128.

Since then we've been on Chrome 130, and the tests are still skipped. If the tests are not useful anymore, they should be removed for good.

If they're in fact testing for important regression, then they should not be skipped, because these issues are potentially showing up on our users' computers (if they're above Chrome 128).

For more info, see:

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 4, 2024

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 4, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #44 / dashboard app - group 1 Changing field formatter to Url applied on discover
  • [job] [logs] FTR Configs #44 / dashboard app - group 1 Changing field formatter to Url applied on discover
  • [job] [logs] FTR Configs #87 / dashboard app - group 5 embed mode default URL params renders as expected
  • [job] [logs] FTR Configs #87 / dashboard app - group 5 embed mode default URL params renders as expected
  • [job] [logs] FTR Configs #1 / kibana overview app overview page - Analytics apps Analytics apps cards should display
  • [job] [logs] FTR Configs #1 / kibana overview app overview page - Analytics apps Analytics apps cards should display
  • [job] [logs] FTR Configs #85 / lens app - group 6 lens workspace size gauge size (absolute pixels) - major arc
  • [job] [logs] FTR Configs #85 / lens app - group 6 lens workspace size gauge size (absolute pixels) - major arc
  • [job] [logs] FTR Configs #95 / maps app documents source search hits layer query should apply layer query to fit to bounds
  • [job] [logs] FTR Configs #95 / maps app documents source search hits layer query should apply layer query to fit to bounds

Metrics [docs]

✅ unchanged

History

@delanni
Copy link
Contributor Author

delanni commented Nov 5, 2024

Ping:

  • @elastic/appex-sharedux
  • @elastic/kibana-gis
  • @elastic/kibana-presentation
  • @elastic/kibana-visualizations

@delanni
Copy link
Contributor Author

delanni commented Nov 28, 2024

Last ping before I close this issue:
@elastic/appex-sharedux
@elastic/kibana-presentation
@elastic/kibana-visualizations

If you are not planning to solve these anytime soon, please create a keepsake issue, so they're not forgotten. Once again, they might expose real incompatibilities with chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants