[CI] unskip tests that were failing on chrome 128, 129 #198807
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These tests were skipped so that we could upgrade to Chrome 128.
Since then we've been on Chrome 130, and the tests are still skipped. If the tests are not useful anymore, they should be removed for good.
If they're in fact testing for important regression, then they should not be skipped, because these issues are potentially showing up on our users' computers (if they're above Chrome 128).
For more info, see: