Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] remove deprecated settings API endpoints #198799

Merged
merged 9 commits into from
Nov 6, 2024
Merged

[Fleet] remove deprecated settings API endpoints #198799

merged 9 commits into from
Nov 6, 2024

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Nov 4, 2024 •
edited
Loading

Summary

Related to #189746

Remove previously deprecated settings API endpoint and response property.

Remove

  • GET/DELETE/POST enrollment-api-keys in favor of GET/DELETE/POST enrollment_api_keys
  • Remove list property from GET enrollment_api_keys response in favor of items
  • GET/POST /settings remove fleet_server_hosts from the response and body

@nchaulet nchaulet mentioned this pull request Nov 4, 2024
Closed
@nchaulet nchaulet self-assigned this Nov 4, 2024
@nchaulet nchaulet added release_note:breaking backport:skip This commit does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team labels Nov 4, 2024
@nchaulet nchaulet force-pushed the feature-remove-last-deprecated-apis branch from 4eff111 to 65a37c8 Compare November 4, 2024 18:36
kibanamachine and others added 2 commits November 4, 2024 19:12
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/capture_oas_snapsho…
3105d51 
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --update'
@nchaulet
fix tests
d87d5ad
@nchaulet nchaulet changed the title [Fleet] remove deprecated API endpoints [Fleet] remove deprecated settings API endpoints Nov 4, 2024
@nchaulet
Merge branch 'feature-remove-last-deprecated-apis' of github.com:ncha…
04bed5b 
…ulet/kibana into feature-remove-last-deprecated-apis
@nchaulet nchaulet marked this pull request as ready for review November 4, 2024 20:15
@nchaulet nchaulet requested review from a team as code owners November 4, 2024 20:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

juliaElastic
juliaElastic approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nchaulet
Copy link
Member Author

nchaulet commented Nov 6, 2024

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.7MB 1.7MB +144.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 173.0KB 172.8KB -224.0B

History

cc @nchaulet

@nchaulet nchaulet merged commit ce9f622 into elastic:main Nov 6, 2024
25 checks passed
mgadewoll pushed a commit to mgadewoll/kibana that referenced this pull request Nov 7, 2024
@nchaulet @mgadewoll
[Fleet] remove deprecated settings API endpoints (elastic#198799)
f95c57c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees

@nchaulet nchaulet

Labels
backport:skip This commit does not require backporting release_note:breaking Team:Fleet Team label for Observability Data Collection Fleet team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nchaulet @elasticmachine @juliaElastic @kibanamachine