[ML] AiOps: Action for adding Log Pattern embeddable to a dashboard and case #198793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbrtj
commented
Nov 4, 2024
| @@ -101,10 +101,6 @@ export const ChartGridEmbeddableWrapper: FC<ChangePointDetectionProps> = ({ | |||
| 10000 | |||
| ); | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
It was causing an error because onLoading is not defined for the chart change point embeddable component.
rbrtj
commented
Nov 4, 2024
| const isCasesEmbeddable = embeddingOrigin === AIOPS_EMBEDDABLE_ORIGIN.CASES; | ||
|
|
||
| // Disable filtering for cases embeddable, as it's not possible to delete filters | ||
| const actions = [...(isCasesEmbeddable ? [] : getActions(false)), ...getActions(true)]; |
There was a problem hiding this comment.
It disables filtering for a pattern in cases. In dashboards, it is possible to delete a filter, but there is currently no such option in cases. I have disabled it for now, but it would be nice to have that option available inside the embeddable.
rbrtj
commented
Nov 4, 2024
|
|
||
| return ( | ||
| <> | ||
| <FieldValidationCallout validationResults={fieldValidationResult} /> | ||
| {(loading ?? true) === true ? <LoadingCategorization onCancel={cancelRequest} /> : null} | ||
| {(loading ?? true) === true ? ( | ||
| <LoadingCategorization onCancel={cancelRequest} disableCancelLoading={isCasesEmbeddable} /> |
There was a problem hiding this comment.
Disabled cancel loading in cases because it is not possible to refresh the embeddable. Therefore, after canceling, the embeddable would get stuck without results.
rbrtj
changed the title
rbrtj
added
release_note:enhancement
:ml
v9.0.0
Team:ML
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
requested review from
jgowdyelastic
and removed request for
peteharverson
Fixes elastic#192804 This PR updates the nav hierarchy on serverless and changes the `accordion` to `panelOpener`. The menu items have been updated according to the [Figma file](https://www.figma.com/design/IAR7FjBaSCDWypNYL83fzy/Observability-Navigation?node-id=1232-10087&node-type=frame&t=AMlUqaK2UhhiyqGi-0). Here's a Video of how nav hierarchy looks like on serverless with the new changes: https://github.com/user-attachments/assets/55d04969-379e-4cd1-8e25-d50382cf51e0 ## What was changed - AI & ML menu is removed and split into - `AI Assistant` - `Machine learning` - `Applications` now opens a `panelOpener` instead of an `accordion` - `Service Inventory` was renamed to `Service inventory` to meet the use of sentence-case requirement - Synthetics was moved to a new section - `Infrastructure` - `Infrastructure Inventory` was renamed to `Infrastructure inventory` to match the sentence-case requirement - `Machine learning`: this menu was not present at all on serverless ## Notes for the Reviewer - `Stack Management` on security and search don't use any `panelOpener`, they use a landing page instead. In order to be consistent with the rest solutions, I kept Stack Management as is. - `Machine Learning` menu item was not present at all on serverless. I need a confirmation, that it is fine to bring it in as it is from stateful cc @vinaychandrasekhar --------- Co-authored-by: Elastic Machine <[email protected]>
Part of elastic#194171. The AIOps plugin loads quite some bundle chunks on the first Kibana load. On main it currently looks like this on page load:  This means while the `aiops.plugin.js` bundle has just 10KB, we load 290KB in total via async bundles on every Kibana full page load. This PR refactors how embeddables and UI actions get initialized to avoid loading any additional async bundles on page load. This increases `aiops.plugin.js` to ~15KB, but gets rid of all the rest!  - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
dmlemeshko
approved these changes
Nov 8, 2024
|
Sorry for the ping! I messed something up in the Git history, so I'm closing the PR for now. |
💔 Build Failed
Failed CI StepsHistory
cc @rbrtj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #197247
Added the ability to add a Log Pattern Embeddable to a dashboard and case.
Fixed the Change Point Detection embeddable in cases and added a functional test to cover this scenario.
Screen.Recording.2024-11-06.at.13.58.01.mov
Checklist
Delete any items that are not applicable to this PR.