Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs Explorer] Fix logs side nav default navigation #198773

Conversation

mohamedhamed-ahmed
Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed commented Nov 4, 2024

closes #198766

@mohamedhamed-ahmed mohamedhamed-ahmed added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.15.0 v8.16.0 backport:version Backport to applied version labels v8.17.0 labels Nov 4, 2024
@mohamedhamed-ahmed mohamedhamed-ahmed requested review from a team as code owners November 4, 2024 12:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mohamedhamed-ahmed mohamedhamed-ahmed added v9.0.0 bug Fixes for quality problems that affect the customer experience labels Nov 4, 2024
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infra ObsUx Changes LGTM 🚀

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 4, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: ecd6d96
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-198773-ecd6d9676872

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.7MB 1.7MB -290.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 56.2KB 56.3KB +54.0B

History

@mohamedhamed-ahmed mohamedhamed-ahmed merged commit 0e4b9e0 into elastic:main Nov 4, 2024
24 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11669096699

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.15 Backport failed because of merge conflicts
8.16 Backport failed because of merge conflicts
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 198773

Questions ?

Please refer to the Backport tool documentation

mohamedhamed-ahmed added a commit to mohamedhamed-ahmed/kibana that referenced this pull request Nov 4, 2024
closes elastic#198766

(cherry picked from commit 0e4b9e0)

# Conflicts:
#	x-pack/plugins/observability_solution/infra/public/plugin.ts
mohamedhamed-ahmed added a commit to mohamedhamed-ahmed/kibana that referenced this pull request Nov 4, 2024
closes elastic#198766

(cherry picked from commit 0e4b9e0)

# Conflicts:
#	x-pack/plugins/observability_solution/infra/public/plugin.ts
mohamedhamed-ahmed added a commit to mohamedhamed-ahmed/kibana that referenced this pull request Nov 4, 2024
closes elastic#198766

(cherry picked from commit 0e4b9e0)

# Conflicts:
#	x-pack/plugins/observability_solution/infra/public/apps/logs_app.tsx
#	x-pack/plugins/observability_solution/infra/public/plugin.ts
@mohamedhamed-ahmed
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x
8.16
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

mohamedhamed-ahmed added a commit that referenced this pull request Nov 5, 2024
…198829)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Logs Explorer] Fix logs side nav default navigation
(#198773)](#198773)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"mohamedhamed-ahmed","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T17:06:13Z","message":"[Logs
Explorer] Fix logs side nav default navigation (#198773)\n\ncloses
https://github.com/elastic/kibana/issues/198766","sha":"0e4b9e0b60e5fe3346a5336b0f7ccca6e08b9eca","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-logs","v8.15.0","v8.16.0","backport:version","v8.17.0"],"number":198773,"url":"https://github.com/elastic/kibana/pull/198773","mergeCommit":{"message":"[Logs
Explorer] Fix logs side nav default navigation (#198773)\n\ncloses
https://github.com/elastic/kibana/issues/198766","sha":"0e4b9e0b60e5fe3346a5336b0f7ccca6e08b9eca"}},"sourceBranch":"main","suggestedTargetBranches":["8.15","8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198773","number":198773,"mergeCommit":{"message":"[Logs
Explorer] Fix logs side nav default navigation (#198773)\n\ncloses
https://github.com/elastic/kibana/issues/198766","sha":"0e4b9e0b60e5fe3346a5336b0f7ccca6e08b9eca"}},{"branch":"8.15","label":"v8.15.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
mohamedhamed-ahmed added a commit that referenced this pull request Nov 5, 2024
…#198830)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Logs Explorer] Fix logs side nav default navigation
(#198773)](#198773)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"mohamedhamed-ahmed","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T17:06:13Z","message":"[Logs
Explorer] Fix logs side nav default navigation (#198773)\n\ncloses
https://github.com/elastic/kibana/issues/198766","sha":"0e4b9e0b60e5fe3346a5336b0f7ccca6e08b9eca","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-logs","v8.15.0","v8.16.0","backport:version","v8.17.0"],"number":198773,"url":"https://github.com/elastic/kibana/pull/198773","mergeCommit":{"message":"[Logs
Explorer] Fix logs side nav default navigation (#198773)\n\ncloses
https://github.com/elastic/kibana/issues/198766","sha":"0e4b9e0b60e5fe3346a5336b0f7ccca6e08b9eca"}},"sourceBranch":"main","suggestedTargetBranches":["8.15","8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198773","number":198773,"mergeCommit":{"message":"[Logs
Explorer] Fix logs side nav default navigation (#198773)\n\ncloses
https://github.com/elastic/kibana/issues/198766","sha":"0e4b9e0b60e5fe3346a5336b0f7ccca6e08b9eca"}},{"branch":"8.15","label":"v8.15.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
mohamedhamed-ahmed added a commit that referenced this pull request Nov 5, 2024
…#198831)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Logs Explorer] Fix logs side nav default navigation
(#198773)](#198773)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"mohamedhamed-ahmed","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T17:06:13Z","message":"[Logs
Explorer] Fix logs side nav default navigation (#198773)\n\ncloses
https://github.com/elastic/kibana/issues/198766","sha":"0e4b9e0b60e5fe3346a5336b0f7ccca6e08b9eca","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-logs","v8.15.0","v8.16.0","backport:version","v8.17.0"],"number":198773,"url":"https://github.com/elastic/kibana/pull/198773","mergeCommit":{"message":"[Logs
Explorer] Fix logs side nav default navigation (#198773)\n\ncloses
https://github.com/elastic/kibana/issues/198766","sha":"0e4b9e0b60e5fe3346a5336b0f7ccca6e08b9eca"}},"sourceBranch":"main","suggestedTargetBranches":["8.15","8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198773","number":198773,"mergeCommit":{"message":"[Logs
Explorer] Fix logs side nav default navigation (#198773)\n\ncloses
https://github.com/elastic/kibana/issues/198766","sha":"0e4b9e0b60e5fe3346a5336b0f7ccca6e08b9eca"}},{"branch":"8.15","label":"v8.15.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels bug Fixes for quality problems that affect the customer experience ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.15.0 v8.15.4 v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs Explorer] Logs side nav default navigation wrongly navigates to Anomalies
5 participants