Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Inventory][ECO] Entities Group By View (#195475) #198686

Merged
merged 1 commit into from
Nov 1, 2024
Merged

[8.x] [Inventory][ECO] Entities Group By View (#195475) #198686

merged 1 commit into from
Nov 1, 2024

Conversation

cauemarcondes
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@Bluefinger
[Inventory][ECO] Entities Group By View (elastic#195475)
2a32633 
# Summary

This PR introduces the API and Page for doing grouped views for the
Inventory Page. Alongside the plain list view, the page now by default
shows a grouped view of entities. In this PR, the only current supported
grouping is by Entity Type.

https://github.com/user-attachments/assets/a07db592-d6c6-4ec1-a00b-bb469908aa6a

Tests TBA

## How to test

- Navigate to the new Inventory Page
- By default, the page should load into a grouped view (Type)
- The page should show all entities currently grouped by their type.
- If a group has enough entities, pagination navigation should only
apply to the list within the group.
- The plain list view should function same as before.
- Using the search/filter bar should function the same with grouped and
list view.

Closes elastic#194740

---------

Co-authored-by: Bryce Buchanan <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit e65ca78)
@cauemarcondes cauemarcondes enabled auto-merge (squash) November 1, 2024 14:16
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@cauemarcondes cauemarcondes merged commit 6ddfb80 into elastic:8.x Nov 1, 2024
31 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
inventory 228 235 +7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inventory 219.1KB 230.3KB +11.1KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
inventory 3 4 +1
Unknown metric groups

ESLint disabled line counts

id before after diff
inventory 1 2 +1

Total ESLint disabled count

id before after diff
inventory 5 6 +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crespocarlos crespocarlos crespocarlos approved these changes

Assignees
No one assigned
Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cauemarcondes @elasticmachine @crespocarlos @Bluefinger