[ES|QL] Fixes the wrongly focused suggestion #198654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
added
release_note:skip
|
Pinging @elastic/kibana-esql (Team:ESQL) |
mbondyra
approved these changes
Nov 4, 2024
|
Starting backport for target branches: 8.x |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 4, 2024
## Summary Removes the wrongly focused panel id. **Now** <img width="421" alt="image" src="https://github.com/user-attachments/assets/31ab675a-349a-49ca-a2aa-8272ff88319d"> **Before** <img width="524" alt="image" src="https://github.com/user-attachments/assets/0483f46c-3cfb-48b7-b32e-ff15e2a285ff"> (cherry picked from commit 867b05e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 4, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Fixes the wrongly focused suggestion (#198654)](#198654) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T13:27:43Z","message":"[ES|QL] Fixes the wrongly focused suggestion (#198654)\n\n## Summary\r\n\r\nRemoves the wrongly focused panel id.\r\n\r\n**Now**\r\n\r\n<img width=\"421\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/31ab675a-349a-49ca-a2aa-8272ff88319d\">\r\n\r\n**Before**\r\n<img width=\"524\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/0483f46c-3cfb-48b7-b32e-ff15e2a285ff\">","sha":"867b05eb586d2d9f36547b4d6dc2a20d975de7a8","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.17.0"],"title":"[ES|QL] Fixes the wrongly focused suggestion","number":198654,"url":"https://github.com/elastic/kibana/pull/198654","mergeCommit":{"message":"[ES|QL] Fixes the wrongly focused suggestion (#198654)\n\n## Summary\r\n\r\nRemoves the wrongly focused panel id.\r\n\r\n**Now**\r\n\r\n<img width=\"421\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/31ab675a-349a-49ca-a2aa-8272ff88319d\">\r\n\r\n**Before**\r\n<img width=\"524\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/0483f46c-3cfb-48b7-b32e-ff15e2a285ff\">","sha":"867b05eb586d2d9f36547b4d6dc2a20d975de7a8"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198654","number":198654,"mergeCommit":{"message":"[ES|QL] Fixes the wrongly focused suggestion (#198654)\n\n## Summary\r\n\r\nRemoves the wrongly focused panel id.\r\n\r\n**Now**\r\n\r\n<img width=\"421\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/31ab675a-349a-49ca-a2aa-8272ff88319d\">\r\n\r\n**Before**\r\n<img width=\"524\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/0483f46c-3cfb-48b7-b32e-ff15e2a285ff\">","sha":"867b05eb586d2d9f36547b4d6dc2a20d975de7a8"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the wrongly focused panel id.
Now
Before
