[Synthetics] Added error track trace to status/tls rule context variable !! #198599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
release_note:fix
v8.16.0
backport:version
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
x-pack/plugins/observability_solution/synthetics/common/rules/synthetics_rule_field_map.ts
Show resolved
Hide resolved
| @@ -51,6 +51,7 @@ export const CertType = t.intersection([ | |||
| '@timestamp': t.string, | |||
| serviceName: t.string, | |||
| errorMessage: t.string, | |||
| errorStackTrace: t.union([t.string, t.null]), | |||
There was a problem hiding this comment.
Why do we need to add t.null? I am trying to understand how it is different, for example, from errorMessage.
There was a problem hiding this comment.
because, it can also be null in heartbeat data
There was a problem hiding this comment.
So, in heartbeat data, errorMessage is always present but not errorStackTrace? Where do you check the heartbeat data type?
There was a problem hiding this comment.
no both can be optional, but error_stack can also be null
...ck/plugins/observability_solution/synthetics/server/alert_rules/status_rule/message_utils.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/uptime/common/rules/uptime_rule_field_map.ts
Show resolved
Hide resolved
maryam-saeidi
approved these changes
Nov 1, 2024
| description: i18n.translate( | ||
| 'xpack.synthetics.alertRules.monitorStatus.actionVariables.state.lastErrorStack', | ||
| { | ||
| defaultMessage: 'Monitor last error stack trace.', |
There was a problem hiding this comment.
Maybe this way, it would be more readable?
Monitor's last error stack trace.
There was a problem hiding this comment.
@paulb-elastic @jasonrhodes, who would be the best person to give a quick review of default messages?
This comment is related to the below screenshot, maybe in this instance we just keep it consistent with the rest but in general I was curious about the process
There was a problem hiding this comment.
For our team I would expect this would be DeDe, ie the docs rep assigned to the area.
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
cnasikas
approved these changes
Nov 1, 2024
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 1, 2024
…ble !! (elastic#198599) ## Summary Fixes elastic#198593 Added error track trace to status/tls rule context variable !! <img width="1725" alt="image" src="https://github.com/user-attachments/assets/d04fb6f3-7505-4a01-8a6f-b1b27d50ecdd"> (cherry picked from commit 5544b1a)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 1, 2024
…ble !! (elastic#198599) ## Summary Fixes elastic#198593 Added error track trace to status/tls rule context variable !! <img width="1725" alt="image" src="https://github.com/user-attachments/assets/d04fb6f3-7505-4a01-8a6f-b1b27d50ecdd"> (cherry picked from commit 5544b1a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 1, 2024
… variable !! (#198599) (#198672) # Backport This will backport the following commits from `main` to `8.x`: - [[Synthetics] Added error track trace to status/tls rule context variable !! (#198599)](#198599) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-01T12:55:20Z","message":"[Synthetics] Added error track trace to status/tls rule context variable !! (#198599)\n\n## Summary\n\nFixes https://github.com/elastic/kibana/issues/198593\n\nAdded error track trace to status/tls rule context variable !!\n\n<img width=\"1725\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d04fb6f3-7505-4a01-8a6f-b1b27d50ecdd\">","sha":"5544b1a31439cd8e53d431a9b118d1445eeb79a4","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0","backport:version","v8.17.0"],"title":"[Synthetics] Added error track trace to status/tls rule context variable !!","number":198599,"url":"https://github.com/elastic/kibana/pull/198599","mergeCommit":{"message":"[Synthetics] Added error track trace to status/tls rule context variable !! (#198599)\n\n## Summary\n\nFixes https://github.com/elastic/kibana/issues/198593\n\nAdded error track trace to status/tls rule context variable !!\n\n<img width=\"1725\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d04fb6f3-7505-4a01-8a6f-b1b27d50ecdd\">","sha":"5544b1a31439cd8e53d431a9b118d1445eeb79a4"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198599","number":198599,"mergeCommit":{"message":"[Synthetics] Added error track trace to status/tls rule context variable !! (#198599)\n\n## Summary\n\nFixes https://github.com/elastic/kibana/issues/198593\n\nAdded error track trace to status/tls rule context variable !!\n\n<img width=\"1725\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d04fb6f3-7505-4a01-8a6f-b1b27d50ecdd\">","sha":"5544b1a31439cd8e53d431a9b118d1445eeb79a4"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Shahzad <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 1, 2024
…t variable !! (#198599) (#198671) # Backport This will backport the following commits from `main` to `8.16`: - [[Synthetics] Added error track trace to status/tls rule context variable !! (#198599)](#198599) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-01T12:55:20Z","message":"[Synthetics] Added error track trace to status/tls rule context variable !! (#198599)\n\n## Summary\n\nFixes https://github.com/elastic/kibana/issues/198593\n\nAdded error track trace to status/tls rule context variable !!\n\n<img width=\"1725\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d04fb6f3-7505-4a01-8a6f-b1b27d50ecdd\">","sha":"5544b1a31439cd8e53d431a9b118d1445eeb79a4","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0","backport:version","v8.17.0"],"title":"[Synthetics] Added error track trace to status/tls rule context variable !!","number":198599,"url":"https://github.com/elastic/kibana/pull/198599","mergeCommit":{"message":"[Synthetics] Added error track trace to status/tls rule context variable !! (#198599)\n\n## Summary\n\nFixes https://github.com/elastic/kibana/issues/198593\n\nAdded error track trace to status/tls rule context variable !!\n\n<img width=\"1725\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d04fb6f3-7505-4a01-8a6f-b1b27d50ecdd\">","sha":"5544b1a31439cd8e53d431a9b118d1445eeb79a4"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198599","number":198599,"mergeCommit":{"message":"[Synthetics] Added error track trace to status/tls rule context variable !! (#198599)\n\n## Summary\n\nFixes https://github.com/elastic/kibana/issues/198593\n\nAdded error track trace to status/tls rule context variable !!\n\n<img width=\"1725\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d04fb6f3-7505-4a01-8a6f-b1b27d50ecdd\">","sha":"5544b1a31439cd8e53d431a9b118d1445eeb79a4"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Shahzad <[email protected]>
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Nov 1, 2024
…ble !! (elastic#198599) ## Summary Fixes elastic#198593 Added error track trace to status/tls rule context variable !! <img width="1725" alt="image" src="https://github.com/user-attachments/assets/d04fb6f3-7505-4a01-8a6f-b1b27d50ecdd">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #198593
Added error track trace to status/tls rule context variable !!