Moves glob to devDependencies #198589
Merged
Moves glob to devDependencies #198589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeramysoucy
added
Team:Security
|
Pinging @elastic/kibana-security (Team:Security) |
jbudz
reviewed
Nov 4, 2024
| @@ -28,7 +28,9 @@ export default function (directory) { | |||
| ); | |||
|
|
|||
| // Get a list of all directories with an index.js, use the directory name as the key in the object | |||
| const directories = _.chain(glob.sync(path.resolve(__dirname, '../' + directory + '/*/index.js'))) | |||
| const directories = _.chain( | |||
| globby.sync(path.resolve(__dirname, '../' + directory + '/*/index.js')) | |||
There was a problem hiding this comment.
This was a tricky one previously, sorry for leaving the backport unaddressed.
d719c89 was needed for it to functions on Windows.
There was a problem hiding this comment.
Thanks @jbudz! I was wondering about that.
There was a problem hiding this comment.
Addressed in 2afa705
SiddharthMantri
approved these changes
Nov 4, 2024
jbudz
reviewed
Nov 4, 2024
src/plugins/console/server/services/spec_definitions_service.ts
Outdated
Show resolved
Hide resolved
SiddharthMantri
approved these changes
Nov 5, 2024
💚 Build Succeeded
Metrics [docs]
History
|
jbudz
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves
globdependencies to devDependencies.