Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Investigations] - update list of dependencies to run cypress tests #198586

Conversation

PhilippeOberti
Copy link
Contributor

@PhilippeOberti PhilippeOberti commented Oct 31, 2024

Summary

This PR updates the list of dependencies that need to be watched to trigger the Cypress tests for the Threat Hunting Investigations team.
The list is unfortunately not exhaustive. I went through all the imports in the following folders:

  • /packages/kbn-expandable-flyout
  • /x-pack/plugins/security_solution/public/timelines
  • /x-pack/plugins/security_solution/public/flyout
  • /x-pack/plugins/security_solution/public/notes

I did not go through the /x-pack/plugins/security_solution/public/common as they were way too many files... Also I did not go through the dependencies of all of our listed dependencies as this would take days...

It is an improvement on what we've had until now though, and should protect us from outside code being changed!

https://github.com/elastic/security-team/issues/10579

@PhilippeOberti PhilippeOberti added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Threat Hunting:Investigations Security Solution Investigations Team backport:version Backport to applied version labels v8.17.0 labels Oct 31, 2024
@PhilippeOberti PhilippeOberti requested a review from a team as a code owner October 31, 2024 16:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@PhilippeOberti PhilippeOberti merged commit 79edde9 into elastic:main Nov 1, 2024
32 checks passed
@PhilippeOberti PhilippeOberti deleted the investigations-pipeline-dependencies branch November 1, 2024 17:11
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11633348587

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 1, 2024
…run cypress tests (elastic#198586)

## Summary

This PR updates the list of dependencies that need to be watched to
trigger the Cypress tests for the Threat Hunting Investigations team.
The list is unfortunately not exhaustive. I went through all the imports
in the following folders:
- `/packages/kbn-expandable-flyout`
- `/x-pack/plugins/security_solution/public/timelines`
- `/x-pack/plugins/security_solution/public/flyout`
- `/x-pack/plugins/security_solution/public/notes`

I did not go through the
`/x-pack/plugins/security_solution/public/common` as they were way too
many files... Also I did not go through the dependencies of all of our
listed dependencies as this would take days...

It is an improvement on what we've had until now though, and should
protect us from outside code being changed!

elastic/security-team#10579
(cherry picked from commit 79edde9)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 1, 2024
…es to run cypress tests (#198586) (#198706)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution][Investigations] - update list of dependencies to
run cypress tests
(#198586)](#198586)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-01T17:11:22Z","message":"[Security
Solution][Investigations] - update list of dependencies to run cypress
tests (#198586)\n\n## Summary\r\n\r\nThis PR updates the list of
dependencies that need to be watched to\r\ntrigger the Cypress tests for
the Threat Hunting Investigations team.\r\nThe list is unfortunately not
exhaustive. I went through all the imports\r\nin the following
folders:\r\n- `/packages/kbn-expandable-flyout`\r\n-
`/x-pack/plugins/security_solution/public/timelines`\r\n-
`/x-pack/plugins/security_solution/public/flyout`\r\n-
`/x-pack/plugins/security_solution/public/notes`\r\n\r\nI did not go
through the\r\n`/x-pack/plugins/security_solution/public/common` as they
were way too\r\nmany files... Also I did not go through the dependencies
of all of our\r\nlisted dependencies as this would take
days...\r\n\r\nIt is an improvement on what we've had until now though,
and should\r\nprotect us from outside code being
changed!\r\n\r\nhttps://github.com/elastic/security-team/issues/10579","sha":"79edde95676ac629c8ae020beff921d3673345df","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat
Hunting:Investigations","backport:version","v8.17.0"],"title":"[Security
Solution][Investigations] - update list of dependencies to run cypress
tests","number":198586,"url":"https://github.com/elastic/kibana/pull/198586","mergeCommit":{"message":"[Security
Solution][Investigations] - update list of dependencies to run cypress
tests (#198586)\n\n## Summary\r\n\r\nThis PR updates the list of
dependencies that need to be watched to\r\ntrigger the Cypress tests for
the Threat Hunting Investigations team.\r\nThe list is unfortunately not
exhaustive. I went through all the imports\r\nin the following
folders:\r\n- `/packages/kbn-expandable-flyout`\r\n-
`/x-pack/plugins/security_solution/public/timelines`\r\n-
`/x-pack/plugins/security_solution/public/flyout`\r\n-
`/x-pack/plugins/security_solution/public/notes`\r\n\r\nI did not go
through the\r\n`/x-pack/plugins/security_solution/public/common` as they
were way too\r\nmany files... Also I did not go through the dependencies
of all of our\r\nlisted dependencies as this would take
days...\r\n\r\nIt is an improvement on what we've had until now though,
and should\r\nprotect us from outside code being
changed!\r\n\r\nhttps://github.com/elastic/security-team/issues/10579","sha":"79edde95676ac629c8ae020beff921d3673345df"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198586","number":198586,"mergeCommit":{"message":"[Security
Solution][Investigations] - update list of dependencies to run cypress
tests (#198586)\n\n## Summary\r\n\r\nThis PR updates the list of
dependencies that need to be watched to\r\ntrigger the Cypress tests for
the Threat Hunting Investigations team.\r\nThe list is unfortunately not
exhaustive. I went through all the imports\r\nin the following
folders:\r\n- `/packages/kbn-expandable-flyout`\r\n-
`/x-pack/plugins/security_solution/public/timelines`\r\n-
`/x-pack/plugins/security_solution/public/flyout`\r\n-
`/x-pack/plugins/security_solution/public/notes`\r\n\r\nI did not go
through the\r\n`/x-pack/plugins/security_solution/public/common` as they
were way too\r\nmany files... Also I did not go through the dependencies
of all of our\r\nlisted dependencies as this would take
days...\r\n\r\nIt is an improvement on what we've had until now though,
and should\r\nprotect us from outside code being
changed!\r\n\r\nhttps://github.com/elastic/security-team/issues/10579","sha":"79edde95676ac629c8ae020beff921d3673345df"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Philippe Oberti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants