Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Response Ops][Alerting] Removing lifecycle executor from rule registry (#192576) #198579

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[8.x] [Response Ops][Alerting] Removing lifecycle executor from rule registry (#192576) #198579

merged 1 commit into from
Oct 31, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@ymao1
[Response Ops][Alerting] Removing lifecycle executor from rule regist…
18392c0 
…ry (elastic#192576)

## Summary

All lifecycle rule types have been migrated to use the alerting
framework alerts client so the lifecycle executor in the rule registry
can be removed since it is no longer in use.

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 322392f)
@kibanamachine kibanamachine enabled auto-merge (squash) October 31, 2024 16:35
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Oct 31, 2024
@kibanamachine kibanamachine mentioned this pull request Oct 31, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibanamachine kibanamachine merged commit 124aff6 into elastic:8.x Oct 31, 2024
32 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #11 / AddComment errors shows an error when comment is empty
  • [job] [logs] Jest Tests #11 / AddComment should insert a quote
  • [job] [logs] Jest Tests #11 / AddComment should post comment on submit click

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
ruleRegistry 248 226 -22

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
ruleRegistry 11 10 -1
Unknown metric groups

API count

id before after diff
ruleRegistry 285 263 -22

ESLint disabled line counts

id before after diff
@kbn/test-suites-xpack 730 729 -1

References to deprecated APIs

id before after diff
ruleRegistry 6 5 -1

Total ESLint disabled count

id before after diff
@kbn/test-suites-xpack 755 754 -1

cc @ymao1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@ymao1 ymao1

Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @elasticmachine @ymao1