Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [ResponseOps]]MaintenaceWindow] Increase MW table limit to 1k (#198504) #198551

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[8.x] [ResponseOps]]MaintenaceWindow] Increase MW table limit to 1k (#198504) #198551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 18 additions & 20 deletions x-pack/plugins/alerting/common/routes/maintenance_window/apis/find/schemas/v1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,26 +12,24 @@ const MAX_DOCS = 10000;

export const findMaintenanceWindowsRequestQuerySchema = schema.object(
{
page: schema.maybe(
schema.number({
defaultValue: 1,
min: 1,
max: MAX_DOCS,
meta: {
description: 'The page number to return.',
},
})
),
per_page: schema.maybe(
schema.number({
defaultValue: 20,
min: 0,
max: 100,
meta: {
description: 'The number of maintenance windows to return per page.',
},
})
),
// we do not need to use schema.maybe here, because if we do not pass property page, defaultValue will be used
page: schema.number({
defaultValue: 1,
min: 1,
max: MAX_DOCS,
meta: {
description: 'The page number to return.',
},
}),
// we do not need to use schema.maybe here, because if we do not pass property per_page, defaultValue will be used
per_page: schema.number({
defaultValue: 1000,
min: 0,
max: 100,
meta: {
description: 'The number of maintenance windows to return per page.',
},
}),
},
{
validate: (params) => {
Expand Down