[ML] Fix Trained model deletion with expanded row #198530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
|
Starting backport for target branches: 8.16, 8.x |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
cc @darnautov |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 31, 2024
## Summary Fixes elastic#198408. Fixes trained model item deletion with expanded row. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit bd21496)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 31, 2024
## Summary Fixes elastic#198408. Fixes trained model item deletion with expanded row. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit bd21496)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 31, 2024
…98568) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Fix Trained model deletion with expanded row (#198530)](#198530) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T15:33:17Z","message":"[ML] Fix Trained model deletion with expanded row (#198530)\n\n## Summary\r\n\r\nFixes #198408.\r\n\r\nFixes trained model item deletion with expanded row.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"bd21496b3c0af2167918bd385bd259b05c8e765d","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v9.0.0","Team:ML","v8.16.0","backport:version","v8.17.0"],"title":"[ML] Fix Trained model deletion with expanded row","number":198530,"url":"https://github.com/elastic/kibana/pull/198530","mergeCommit":{"message":"[ML] Fix Trained model deletion with expanded row (#198530)\n\n## Summary\r\n\r\nFixes #198408.\r\n\r\nFixes trained model item deletion with expanded row.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"bd21496b3c0af2167918bd385bd259b05c8e765d"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198530","number":198530,"mergeCommit":{"message":"[ML] Fix Trained model deletion with expanded row (#198530)\n\n## Summary\r\n\r\nFixes #198408.\r\n\r\nFixes trained model item deletion with expanded row.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"bd21496b3c0af2167918bd385bd259b05c8e765d"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dima Arnautov <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 31, 2024
…198567) # Backport This will backport the following commits from `main` to `8.16`: - [[ML] Fix Trained model deletion with expanded row (#198530)](#198530) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T15:33:17Z","message":"[ML] Fix Trained model deletion with expanded row (#198530)\n\n## Summary\r\n\r\nFixes #198408.\r\n\r\nFixes trained model item deletion with expanded row.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"bd21496b3c0af2167918bd385bd259b05c8e765d","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v9.0.0","Team:ML","v8.16.0","backport:version","v8.17.0"],"title":"[ML] Fix Trained model deletion with expanded row","number":198530,"url":"https://github.com/elastic/kibana/pull/198530","mergeCommit":{"message":"[ML] Fix Trained model deletion with expanded row (#198530)\n\n## Summary\r\n\r\nFixes #198408.\r\n\r\nFixes trained model item deletion with expanded row.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"bd21496b3c0af2167918bd385bd259b05c8e765d"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198530","number":198530,"mergeCommit":{"message":"[ML] Fix Trained model deletion with expanded row (#198530)\n\n## Summary\r\n\r\nFixes #198408.\r\n\r\nFixes trained model item deletion with expanded row.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"bd21496b3c0af2167918bd385bd259b05c8e765d"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dima Arnautov <[email protected]>
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Nov 1, 2024
## Summary Fixes elastic#198408. Fixes trained model item deletion with expanded row. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #198408.
Fixes trained model item deletion with expanded row.
Checklist